From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support Date: Thu, 22 Jan 2015 09:07:23 +0100 Message-ID: <20150122090723.50ac0156@armhf> References: <54C0088F.9070609@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <54C0088F.9070609-Qo5EllUWu/uELgA04lAiVw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lars-Peter Clausen Cc: Mark Brown , Kuninori Morimoto , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, Russell King - ARM Linux , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jyri Sarha List-Id: alsa-devel@alsa-project.org On Wed, 21 Jan 2015 21:14:07 +0100 Lars-Peter Clausen wrote: > [...] > > + card->dai_link->dai_fmt =3D > > + snd_soc_of_parse_daifmt(of_cpu, "dt-audio-card,", > > + NULL, NULL) & > > + ~SND_SOC_DAIFMT_MASTER_MASK; >=20 >=20 > This one does not seem to be in the bindings documentation. Sorry, I forgot to remove it from the patch. BTW, the graph of port should also contain pieces of the audio specific hardware information as the ones found in the simple-card (clock, GPIO, ...). This information could be written as generic device node properties. i.e without any prefix. I was also wondering about some of these properties, as widgets and routing. They seem to be software information and Linux specific. Must these properties appear in the DTs? --=20 Ken ar c'henta=C3=B1 | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbbAVIHv (ORCPT ); Thu, 22 Jan 2015 03:07:51 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]:41974 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbbAVIHk convert rfc822-to-8bit (ORCPT ); Thu, 22 Jan 2015 03:07:40 -0500 Date: Thu, 22 Jan 2015 09:07:23 +0100 From: Jean-Francois Moine To: Lars-Peter Clausen Cc: Mark Brown , Kuninori Morimoto , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Russell King - ARM Linux , linux-kernel@vger.kernel.org, Jyri Sarha Subject: Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support Message-ID: <20150122090723.50ac0156@armhf> In-Reply-To: <54C0088F.9070609@metafoo.de> References: <54C0088F.9070609@metafoo.de> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Jan 2015 21:14:07 +0100 Lars-Peter Clausen wrote: > [...] > > + card->dai_link->dai_fmt = > > + snd_soc_of_parse_daifmt(of_cpu, "dt-audio-card,", > > + NULL, NULL) & > > + ~SND_SOC_DAIFMT_MASTER_MASK; > > > This one does not seem to be in the bindings documentation. Sorry, I forgot to remove it from the patch. BTW, the graph of port should also contain pieces of the audio specific hardware information as the ones found in the simple-card (clock, GPIO, ...). This information could be written as generic device node properties. i.e without any prefix. I was also wondering about some of these properties, as widgets and routing. They seem to be software information and Linux specific. Must these properties appear in the DTs? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/