From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices Date: Thu, 22 Jan 2015 10:56:05 +0000 Message-ID: <20150122105605.GB9129@x1> References: <1420205572-2640-1-git-send-email-javier.martinez@collabora.co.uk> <1420205572-2640-4-git-send-email-javier.martinez@collabora.co.uk> <20150120081104.GT21886@x1> <54BE7B08.1010900@collabora.co.uk> <20150120163410.GC30656@x1> <54BE87C4.4040108@collabora.co.uk> <20150122084244.GP22024@x1> <54C0BE21.7020008@collabora.co.uk> <20150122094608.GA5769@x1> <54C0D29C.4010904@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ig0-f170.google.com ([209.85.213.170]:38044 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbbAVK4L (ORCPT ); Thu, 22 Jan 2015 05:56:11 -0500 Received: by mail-ig0-f170.google.com with SMTP id l13so297756iga.1 for ; Thu, 22 Jan 2015 02:56:11 -0800 (PST) Content-Disposition: inline In-Reply-To: <54C0D29C.4010904@collabora.co.uk> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Javier Martinez Canillas Cc: Olof Johansson , Doug Anderson , Bill Richardson , Simon Glass , Gwendal Grignou , Jonathan Corbet , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de On Thu, 22 Jan 2015, Javier Martinez Canillas wrote: > On 01/22/2015 10:46 AM, Lee Jones wrote: > >>=20 > >> But there doesn't seem to be a LPC subsystem in the kernel so we d= on't have a > >> nice abstraction layer in this case. > >=20 > > This is the crux of the problem. However, I feel bad for MFD, as i= t > > is, once more, being used as an "well it doesn't fit anywhere else,= so > > let's shoehorn it in there" type of dumping ground. > > > Yes, I completely understand your point, is that I didn't think that = a ~300 > lines driver was that bad specially since the communication bits that= reads > and writes the register is not a complex logic IMHO. This has nothing to do with LoC, it's the principle of the matter. > >> > Are there any other Low Pin Count drivers in the kernel? > >> > > >>=20 > >> I don't know tbh, I didn't even know what LPC was before I picked = this patch > >> to push it upstream. I searched in the Linux codebase for other LP= C drivers > >> but I didn't find anything, that doesn't mean that it doesn't exis= t though. > >=20 > > I agree. Perhaps a suitable driver should live in drivers/misc unt= il > > there are enough of them to warrant its own subsystem. > > >=20 > Yes, I can move the driver to drivers/misc if you think that is more = suitable > to be there. >=20 > I've taken another look and AFAICT there are two other mfd drivers th= at use an > LPC bus, these are drivers/mfd/lpc_{i,s}ch.c for Intel's I/O Controll= er HUB and=20 > System Controller Hub respectively. These looked like PCI aggregates when I looked at them last? --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog