From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 03/36] drm/plane: Add optional ->atomic_disable() callback Date: Thu, 22 Jan 2015 16:57:50 -0200 Message-ID: <20150122185750.GJ2001@joana> References: <1421750935-4023-1-git-send-email-thierry.reding@gmail.com> <1421750935-4023-4-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1421750935-4023-4-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: linux-tegra@vger.kernel.org MjAxNS0wMS0yMCBUaGllcnJ5IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwuY29tPjoKCj4g RnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBJbiBvcmRlciB0 byBwcmV2ZW50IGRyaXZlcnMgZnJvbSBoYXZpbmcgdG8gcGVyZm9ybSB0aGUgc2FtZSBjaGVja3Mg b3Zlcgo+IGFuZCBvdmVyIGFnYWluLCBhZGQgYW4gb3B0aW9uYWwgLT5hdG9taWNfZGlzYWJsZSBj YWxsYmFjayB3aGljaCB0aGUgY29yZQo+IGNhbGxzIHVuZGVyIHRoZSByaWdodCBjaXJjdW1zdGFu Y2VzLgo+IAo+IHYyOiBwYXNzIG9sZCBzdGF0ZSBhbmQgZGV0ZWN0IGVkZ2VzIHRvIGF2b2lkIGNh bGxpbmcgLT5hdG9taWNfZGlzYWJsZSBvbgo+IGFscmVhZHkgZGlzYWJsZWQgcGxhbmVzLCByZW1v dmUgcmVkdW5kYW50IGNvbW1lbnQgKERhbmllbCBWZXR0ZXIpCj4gCj4gdjM6IHJlbmFtZSBoZWxw ZXIgdG8gZHJtX2F0b21pY19wbGFuZV9kaXNhYmxpbmcoKSB0byBjbGFyaWZ5IHRoYXQgaXQgaXMK PiBjaGVja2luZyBmb3IgdHJhbnNpdGlvbnMsIG1vdmUgaGVscGVyIHRvIGRybV9hdG9taWNfaGVs cGVyLmgsIGNsYXJpZnkKPiBjaGVjayBmb3IgIW9sZF9zdGF0ZSBhbmQgaXRzIHJlbGF0aW9uIHRv IHRyYW5zaXRpb25hbCBoZWxwZXJzCj4gCj4gU2lnbmVkLW9mZi1ieTogVGhpZXJyeSBSZWRpbmcg PHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNf aGVscGVyLmMgfCAgOSArKysrKysrKy0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZV9oZWxw ZXIuYyAgfCAxMCArKysrKysrKystCj4gIGluY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmgg ICAgIHwgMzcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRl L2RybS9kcm1fcGxhbmVfaGVscGVyLmggICAgICB8ICAzICsrKwo+ICA0IGZpbGVzIGNoYW5nZWQs IDU3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpSZXZpZXdlZC1ieTogR3VzdGF2byBQ YWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgoKCUd1c3Rhdm8KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753861AbbAVS6F (ORCPT ); Thu, 22 Jan 2015 13:58:05 -0500 Received: from mail-qc0-f177.google.com ([209.85.216.177]:60094 "EHLO mail-qc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753475AbbAVS54 (ORCPT ); Thu, 22 Jan 2015 13:57:56 -0500 Date: Thu, 22 Jan 2015 16:57:50 -0200 From: Gustavo Padovan To: Thierry Reding Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/36] drm/plane: Add optional ->atomic_disable() callback Message-ID: <20150122185750.GJ2001@joana> Mail-Followup-To: Gustavo Padovan , Thierry Reding , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <1421750935-4023-1-git-send-email-thierry.reding@gmail.com> <1421750935-4023-4-git-send-email-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1421750935-4023-4-git-send-email-thierry.reding@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-01-20 Thierry Reding : > From: Thierry Reding > > In order to prevent drivers from having to perform the same checks over > and over again, add an optional ->atomic_disable callback which the core > calls under the right circumstances. > > v2: pass old state and detect edges to avoid calling ->atomic_disable on > already disabled planes, remove redundant comment (Daniel Vetter) > > v3: rename helper to drm_atomic_plane_disabling() to clarify that it is > checking for transitions, move helper to drm_atomic_helper.h, clarify > check for !old_state and its relation to transitional helpers > > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/drm_atomic_helper.c | 9 ++++++++- > drivers/gpu/drm/drm_plane_helper.c | 10 +++++++++- > include/drm/drm_atomic_helper.h | 37 +++++++++++++++++++++++++++++++++++++ > include/drm/drm_plane_helper.h | 3 +++ > 4 files changed, 57 insertions(+), 2 deletions(-) Reviewed-by: Gustavo Padovan Gustavo