From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
Doug Anderson <dianders@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Simon Glass <sjg@google.com>,
Gwendal Grignou <gwendal@google.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device
Date: Fri, 23 Jan 2015 10:26:55 +0000 [thread overview]
Message-ID: <20150123102655.GH9129@x1> (raw)
In-Reply-To: <1421954186-29764-6-git-send-email-javier.martinez@collabora.co.uk>
On Thu, 22 Jan 2015, Javier Martinez Canillas wrote:
> The ChromeOS EC character device is an user-space interface to
> allow applications to access the Embedded Controller.
>
> Add a cell for this device so it's spawned from the mfd driver.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Changes since v2:
> - Rename the name to "cros-ec-ctl". Suggested by Lee Jones.
>
> Changes since v1: None, new patch.
> ---
> drivers/mfd/cros_ec.c | 4 ++++
> 1 file changed, 4 insertions(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index c872e1b0eaf8..c4aecc6f8373 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -118,6 +118,10 @@ static const struct mfd_cell cros_devs[] = {
> .id = 2,
> .of_compatible = "google,cros-ec-i2c-tunnel",
> },
> + {
> + .name = "cros-ec-ctl",
> + .id = 3,
> + },
> };
>
> int cros_ec_register(struct cros_ec_device *ec_dev)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-01-23 10:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 19:16 [PATCH v3 0/7] platform/chrome: Add user-space dev inferface support Javier Martinez Canillas
2015-01-22 19:16 ` [PATCH v3 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC Javier Martinez Canillas
2015-01-22 19:16 ` [PATCH v3 2/7] mfd: cros_ec: Add char dev and virtual dev pointers Javier Martinez Canillas
2015-01-22 19:16 ` [PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices Javier Martinez Canillas
2015-01-23 3:57 ` Varka Bhadram
2015-01-23 9:55 ` Javier Martinez Canillas
2015-01-22 19:16 ` [PATCH v3 4/7] platform/chrome: Add Chrome OS EC userspace device interface Javier Martinez Canillas
2015-01-22 19:16 ` [PATCH v3 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device Javier Martinez Canillas
2015-01-23 10:26 ` Lee Jones [this message]
2015-01-22 19:16 ` [PATCH v3 6/7] platform/chrome: Create sysfs attributes for the ChromeOS EC Javier Martinez Canillas
2015-01-22 19:16 ` [PATCH v3 7/7] platform/chrome: Expose Chrome OS Lightbar to users Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123102655.GH9129@x1 \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=dianders@chromium.org \
--cc=gwendal@google.com \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sjg@google.com \
--cc=wfrichar@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.