Re: [Qemu-devel] [PATCH v3 0/6] Update filename string sizes in block layer

[Kevin Wolf <kwolf@redhat.com>]

Am 22.01.2015 um 14:03 hat Jeff Cody geschrieben:
> The block layer uses a mixture of 'PATH_MAX' and '1024' string sizes
> for filenames (and backing filenames).
> 
> This series consolidates all that usage to 'PATH_MAX'.  Since most platforms
> (especially the most common platforms for QEMU) have a PATH_MAX larger than
> 1024 bytes, this series also changes stack allocations of PATH_MAX to be
> dynamically allocated.
> 
> Note: checkpatch.pl complains about an extra space in a printf in
>       patches 1 & 2.  The lines complained about are in the diff context and
>       not the actual changes, so I did not fix them up to satisfy checkpatch.
> 
> Changes from v3:
>     - simplified extent_path handling in vmdk_parse_extents() (Thanks Stefan)
>     - moved declaration of backing_filename2 to inside if
>       statement in bdrv_query_image_info() (Thanks Stefan)
>     - removed zombie variable in bdrv_commit (Thanks Stefan)
>     - fixed typo in commit message (Thanks Stefan)
> 
> Changes from v2:
> 
>     - Change stack allocations to dybnamic (Thanks Kevin)
>     - Update qcow/qcow2 ti perform safety checks for platforms that
>       have a PATH_MAX < 1024 (thanks John, Kevin).

Thanks, applied to the block branch.

Kevin