All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Wyckoff <pw@padd.com>
To: Luke Diamand <luke@diamand.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-p4: correct --prepare-p4-only instructions
Date: Fri, 23 Jan 2015 13:39:20 -0800	[thread overview]
Message-ID: <20150123213920.GA3779@padd.com> (raw)
In-Reply-To: <1422004512-10049-2-git-send-email-luke@diamand.org>

luke@diamand.org wrote on Fri, 23 Jan 2015 09:15 +0000:
> If you use git-p4 with the "--prepare-p4-only" option, then
> it prints the p4 command line to use. However, the command
> line was incorrect: the changelist specification must be
> supplied on standard input, not as an argument to p4.
> 
> Signed-off-by: Luke Diamand <luke@diamand.org>
> ---
>  git-p4.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git-p4.py b/git-p4.py
> index ff132b2..90447de 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -1442,7 +1442,7 @@ class P4Submit(Command, P4UserMap):
>              print "  " + self.clientPath
>              print
>              print "To submit, use \"p4 submit\" to write a new description,"
> -            print "or \"p4 submit -i %s\" to use the one prepared by" \
> +            print "or \"p4 submit -i <%s\" to use the one prepared by" \
>                    " \"git p4\"." % fileName
>              print "You can delete the file \"%s\" when finished." % fileName
>  

Looks obviously good here.  Ack!

		-- Pete

      reply	other threads:[~2015-01-23 21:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23  9:15 [PATCH] git-p4: correct --prepare-p4-only instructions Luke Diamand
2015-01-23  9:15 ` Luke Diamand
2015-01-23 21:39   ` Pete Wyckoff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150123213920.GA3779@padd.com \
    --to=pw@padd.com \
    --cc=git@vger.kernel.org \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.