From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YEjW0-00030T-QW for mharc-grub-devel@gnu.org; Fri, 23 Jan 2015 14:03:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEjVz-0002zJ-0Z for grub-devel@gnu.org; Fri, 23 Jan 2015 14:03:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEjVv-0005ox-BD for grub-devel@gnu.org; Fri, 23 Jan 2015 14:03:30 -0500 Received: from mail-la0-x236.google.com ([2a00:1450:4010:c03::236]:42011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEjVv-0005om-39 for grub-devel@gnu.org; Fri, 23 Jan 2015 14:03:27 -0500 Received: by mail-la0-f54.google.com with SMTP id hv19so8902089lab.13 for ; Fri, 23 Jan 2015 11:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=Bu9RG9i5rN25tHKlA71pEkLYjDgYlSjLNNY0ZRbZ6Io=; b=XNi/PDo80XlJydt6khwccEbL87HE4OgBMr4/GEGAEGqUscFz8cXfDDPLdC9VLg9paL teacYzYCqkVxk1U+fsQgd/I62Wf8fkXqOysD0gxoHYr73fXFF/IMt6dFWDEE0YZ5RCNv 5q+QgwIO1VEqKKc+1j2e3a1w+MJP9EjYGY/emNEgE+uRzV/7RyLYdDI+BK4aTJuK/1Vg Yy5JEEmQvLQYpkBK4NgTpmiNPAplVD9EfIMs5hna+ykxqYnbglZgtrYl9ENWLowL3IOT ut4jzy8GRqYA8r4GN5lTh+nN4nLkHf4YwQQ2EY+ydc41m1z06KOWSJ44Ryt5j0l3atnS Xv8Q== X-Received: by 10.112.131.1 with SMTP id oi1mr8929645lbb.2.1422039806088; Fri, 23 Jan 2015 11:03:26 -0800 (PST) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id vl1sm658459lbb.21.2015.01.23.11.03.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jan 2015 11:03:24 -0800 (PST) Date: Fri, 23 Jan 2015 22:03:23 +0300 From: Andrei Borzenkov To: Vladimir =?UTF-8?B?J8+GLWNvZGVyL3BoY29kZXIn?= Serbinenko Subject: Re: Does grub-mkrescue support UEFI hybrid USB/DVD images? Message-ID: <20150123220323.3fc642f0@opensuse.site> In-Reply-To: <20150123213827.6f4279cc@opensuse.site> References: <54C16AD2.7090808@pcbsd.org> <54C17680.9080804@gmail.com> <54C21824.6060407@gmail.com> <20150123205839.1af3ce51@opensuse.site> <54C292F3.2020102@gmail.com> <20150123213827.6f4279cc@opensuse.site> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/wVVyL.9blomuNsLNs2ZFrBm"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::236 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 19:03:32 -0000 --Sig_/wVVyL.9blomuNsLNs2ZFrBm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Fri, 23 Jan 2015 21:38:27 +0300 Andrei Borzenkov =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > =D0=92 Fri, 23 Jan 2015 19:29:07 +0100 > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >=20 > >=20 > > > But returning (hd0,gpt2) would also be wrong here - ESP on CD image is > > > empty, we need to somehow jump from ESP to full ISO image. > > >=20 > > Returning hd0,gpt2 is fine. By convention ()/file refers to parent disk > > of whatever root partition is (as opposed to /file). >=20 > Not sure I follow. If you include part_gpt, grub will set prefix to > (hd0,gpt2)/boot/grub. But /boot/grub does NOT exist there - it exists > on (hd0), so correct prefix is (hd0)/boot/grub. >=20 Ah, OK, I see. Sorry. > > So just including part_gpt in core should be enough. But perhaps we > > should put my patch as well to increase reliability. Consider scenario > > of installing on disk with gpt and apt and using apt partitions. GRUB > > will properly detect that it needs part_apple but part_gpt is not needed > > to access partition. > > Most of the install tools specify partition explicitly, so having > > partition is non-critical. Having disk on the hand is critical. > >=20 > > @Kris: Please try (after removing the other patch) Yes, it works. > > diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c > > index e719839..e02340f 100644 > > --- a/util/grub-mkrescue.c > > +++ b/util/grub-mkrescue.c > > @@ -653,6 +653,9 @@ main (int argc, char *argv[]) > > char *efiimgfat; > > grub_install_mkdir_p (efidir_efi_boot); > >=20 > > + grub_install_push_module ("part_gpt"); > > + grub_install_push_module ("part_msdos"); > > + > > imgname =3D grub_util_path_concat (2, efidir_efi_boot, "bootia64= .efi"); > > make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_IA64_EFI, > > "ia64-efi", imgname); > > free (imgname); > > @@ -713,6 +716,8 @@ main (int argc, char *argv[]) > > free (efiimgfat); > > free (efidir_efi); > > free (efidir); > > + grub_install_pop_module (); > > + grub_install_pop_module (); > > } > >=20 > > grub_install_push_module ("part_apple"); > >=20 > >=20 >=20 --Sig_/wVVyL.9blomuNsLNs2ZFrBm Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlTCmvsACgkQR6LMutpd94zMagCdG/QxAeIMKo42ASTRwehwlNli OpgAn2iAbubQ+8zHtO0Etq9cQYbGyWba =bDKA -----END PGP SIGNATURE----- --Sig_/wVVyL.9blomuNsLNs2ZFrBm--