From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [BUG, bisect] drm/i915: mouse pointer lags and overshoots Date: Sat, 24 Jan 2015 12:24:55 +0100 Message-ID: <20150124112455.GE10113@phenom.ffwll.local> References: <20150117100635.GA1281@hudson.localdomain> <20150119090847.GQ10649@intel.com> <54BCE1BF.5050808@intel.com> <20150119110404.GA26577@nuc-i3427.alporthouse.com> <20150119164024.GI22549@intel.com> <20150120054842.GN26519@phenom.ffwll.local> <20150124065732.GA17057@hudson.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 811686E501 for ; Sat, 24 Jan 2015 03:25:00 -0800 (PST) Received: by mail-we0-f174.google.com with SMTP id x3so1728634wes.5 for ; Sat, 24 Jan 2015 03:24:59 -0800 (PST) Content-Disposition: inline In-Reply-To: <20150124065732.GA17057@hudson.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jeremiah Mahler , Matt Roper , Chris Wilson , Daniel Vetter , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Jani Nikula , David Airlie , Alex Deucher , Dave Airlie , Ander Conselvan de Oliveira , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKYW4gMjMsIDIwMTUgYXQgMTA6NTc6MzJQTSAtMDgwMCwgSmVyZW1pYWggTWFobGVy IHdyb3RlOgo+IGFsbCwKPiAKPiBPbiBUdWUsIEphbiAyMCwgMjAxNSBhdCAwNjo0ODo0MkFNICsw MTAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gT24gTW9uLCBKYW4gMTksIDIwMTUgYXQgMDg6 NDA6MjRBTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90ZToKPiA+ID4gT24gTW9uLCBKYW4gMTksIDIw MTUgYXQgMTE6MDQ6MDRBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+ID4gPiA+IE9uIE1v biwgSmFuIDE5LCAyMDE1IGF0IDExOjUxOjQzQU0gKzAxMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6 Cj4gPiA+ID4gPiBUaGVyZSdzIGFsc28gYW4gaXNzdWUgaW4gKG1vc3QpIFggZHJpdmVycyB3aGlj aCBleGFiZXJhdGVzIHRoaXMKPiA+ID4gPiA+IGlzc3VlczogV2hlbiBjaGFuZ2luZyB0aGUgY3Vy c29yIGJ1ZmZlciB0aGUgWCBjdXJzb3IgY29kZSBkb2VzIGEgYSkKPiA+ID4gPiA+IGRpc2FibGUg Y3Vyc29yIGIpIHVwZGF0ZSBjdXJzb3IgaW1hZ2UgYykgZW5hYmxlIGN1cnNvciBjeWNsZS4KPiA+ ID4gPiAKPiA+ID4gPiBOb3RhYmx5IG5vdCAtaW50ZWwgb24gd2hpY2ggdGhlIGJ1ZyBoYXMgYmVl biBvYnNlcnZlZC4gQW5kIG1vcmUKPiA+ID4gPiBpbXBvcnRhbnRseSwgdGhlIHNsb3cgZG93bnMg ZG9uJ3Qgc2VlbSB0byBjb3JyZWxhdGUgd2l0aCBjdXJzb3IgY2hhbmdlLAo+ID4gPiA+IGp1c3Qg Y3Vyc29yIG1vdmVtZW50Lgo+ID4gPiA+IC1DaHJpcwo+ID4gPiA+IAo+ID4gPiA+IC0tIAo+ID4g PiA+IENocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUKPiA+ ID4gCj4gPiA+IEl0IHNlZW1zIHRoYXQgdGhlIHNpbXBsZSBmaXggZm9yIHRoaXMgY2FzZSAobW92 ZW1lbnQgb25seSkgaXMgdG8ganVzdAo+ID4gPiBza2lwIHRoZSBwcmVwYXJlX2ZiL2NsZWFudXBf ZmIgY2FsbHMgKGFuZCB0aGUgYXNzb2NpYXRlZCB2Ymxhbmsgd2FpdCkgaW4KPiA+ID4gdGhlIHRy YW5zaXRpb25hbCBwbGFuZSBoZWxwZXIgd2hlbiBuZXdmYiA9PSBvbGRmYi4gIEkganVzdCBwb3N0 ZWQgYQo+ID4gPiBzbWFsbCBwYXRjaCB0aGF0IG1ha2VzIHRoYXQgY2hhbmdlIChhbmQgc29sdmVz IHRoZSBjdXJzb3IgbGFnIGZvciBtZSkuCj4gPiA+IAo+ID4gPiBUaGlzIHdvbid0IHNvbHZlIHRo ZSBjYXNlIGlmIHVzZXJzcGFjZSB1c2VzIGEgZGlmZmVyZW50IGZyYW1lYnVmZmVyIGZvcgo+ID4g PiBlYWNoIHVwZGF0ZSAod2hpbGUgdHJ5aW5nIHRvIHVwZGF0ZSBmYXN0ZXIgdGhhbiB0aGUgcmVm cmVzaCByYXRlKS4gIElzCj4gPiA+IHRoZXJlIGFueSBleGlzdGluZyB1c2Vyc3BhY2UgdGhhdCBi ZWhhdmVzIHRoaXMgd2F5IHRoYXQgd2UgY2FuIHRlc3QKPiA+ID4gd2l0aD8KPiA+IAo+ID4gSG0s IEkndmUgdGhvdWdodCBJJ3ZlIG1lcmdlZCB0aGF0IHBhdGNoIGFscmVhZHk6Cj4gPiAKPiA+IGNv bW1pdCBhYjU4ZTMzODRiOWY5ODYzYmZkMDI5YjQ1OGZmMzM3ZDM4MWJmNmQyCj4gPiBBdXRob3I6 IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gPiBEYXRlOiAgIE1vbiBO b3YgMjQgMjA6NDI6NDIgMjAxNCArMDEwMAo+ID4gCj4gPiAgICAgZHJtL2F0b21pYy1oZWxwZXI6 IFNraXAgdmJsYW5rIHdhaXRzIGZvciB1bmNoYW5nZWQgZmJzCj4gPiAKPiA+IE9yIGlzIHRoZSBw cm9ibGVtIGhlcmUgdGhhdCB0aGUgdHJhbnNpdGlvbmFsIHBsYW5lIGhlbHBlcnMgYXJlbid0IHVw IHRvCj4gPiB0aGUgdGFzaz8gSWYgc28gcGxlYXNlIHJlZmVyZW5jZSB0aGF0IGluIHlvdXIgcGF0 Y2guCj4gPiAKPiA+IEFuZCB3ZSBzdGlsbCBuZWVkIGEgaGFjayBmb3IgdGhlICJjaGFuZ2VkIGZi IGN1cnNvciIgaXNzdWUsIEknbGwgd2hpcAo+ID4gc29tZXRoaW5nIHVwLgo+ID4gLURhbmllbAo+ ID4gLS0gCj4gPiBEYW5pZWwgVmV0dGVyCj4gPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KPiA+ICs0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gK PiAKPiBKdXN0IGNoZWNraW5nIGlmIGFueW9uZSBoYXMgY29tZSB1cCB3aXRoIGEgZml4LiAgSSBh bSBzdGlsbCBzdHVjayBhdAo+IG5leHQtMjAxNTAxMTIgYmVjYXVzZSBvZiB0aGlzIGJ1Zy4KCkkn dmUgbWVyZ2VkIGEgcGF0Y2ggZnJvbSBNYXR0IFJvcGVyOgoKY29tbWl0IGQ5OWI3MGNlN2Q3M2Q3 OGE4ODMxMTQ1M2NjZGQwZmEwYTY3MGRkNTAKQXV0aG9yOiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQu cm9wZXJAaW50ZWwuY29tPgpEYXRlOiAgIE1vbiBKYW4gMTkgMDg6MzE6NDkgMjAxNSAtMDgwMAoK ICAgIGRybS9wbGFuZS1oZWxwZXI6IFNraXAgcHJlcGFyZV9mYi9jbGVhbnVwX2ZiIHdoZW4gbmV3 ZmI9PW9sZGZiCgp0aGF0IHNob3VsZCByZWN0aWZ5IHRoZSBzbHVnZ2lzaCBpOTE1IGN1cnNvci4g QnV0IGl0J3MgaW4gYSBzZXBhcmF0ZSB0b3BpYwpicmFuY2ggd2hpY2ggaXNuJ3QgaW4gbGludXgt bmV4dC4gU2hvdWxkIHNob3cgdXAgaW4gZHJtLW5leHQgbmV4dCB3ZWVrCnRob3VnaC4KLURhbmll bAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K KzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752832AbbAXLZG (ORCPT ); Sat, 24 Jan 2015 06:25:06 -0500 Received: from mail-we0-f171.google.com ([74.125.82.171]:55349 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbbAXLZB (ORCPT ); Sat, 24 Jan 2015 06:25:01 -0500 Date: Sat, 24 Jan 2015 12:24:55 +0100 From: Daniel Vetter To: Jeremiah Mahler , Matt Roper , Chris Wilson , Daniel Vetter , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Jani Nikula , David Airlie , Alex Deucher , Dave Airlie , Ander Conselvan de Oliveira , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [BUG, bisect] drm/i915: mouse pointer lags and overshoots Message-ID: <20150124112455.GE10113@phenom.ffwll.local> Mail-Followup-To: Jeremiah Mahler , Matt Roper , Chris Wilson , Daniel Vetter , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Jani Nikula , David Airlie , Alex Deucher , Dave Airlie , Ander Conselvan de Oliveira , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20150117100635.GA1281@hudson.localdomain> <20150119090847.GQ10649@intel.com> <54BCE1BF.5050808@intel.com> <20150119110404.GA26577@nuc-i3427.alporthouse.com> <20150119164024.GI22549@intel.com> <20150120054842.GN26519@phenom.ffwll.local> <20150124065732.GA17057@hudson.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150124065732.GA17057@hudson.localdomain> X-Operating-System: Linux phenom 3.16-2-amd64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 23, 2015 at 10:57:32PM -0800, Jeremiah Mahler wrote: > all, > > On Tue, Jan 20, 2015 at 06:48:42AM +0100, Daniel Vetter wrote: > > On Mon, Jan 19, 2015 at 08:40:24AM -0800, Matt Roper wrote: > > > On Mon, Jan 19, 2015 at 11:04:04AM +0000, Chris Wilson wrote: > > > > On Mon, Jan 19, 2015 at 11:51:43AM +0100, Daniel Vetter wrote: > > > > > There's also an issue in (most) X drivers which exaberates this > > > > > issues: When changing the cursor buffer the X cursor code does a a) > > > > > disable cursor b) update cursor image c) enable cursor cycle. > > > > > > > > Notably not -intel on which the bug has been observed. And more > > > > importantly, the slow downs don't seem to correlate with cursor change, > > > > just cursor movement. > > > > -Chris > > > > > > > > -- > > > > Chris Wilson, Intel Open Source Technology Centre > > > > > > It seems that the simple fix for this case (movement only) is to just > > > skip the prepare_fb/cleanup_fb calls (and the associated vblank wait) in > > > the transitional plane helper when newfb == oldfb. I just posted a > > > small patch that makes that change (and solves the cursor lag for me). > > > > > > This won't solve the case if userspace uses a different framebuffer for > > > each update (while trying to update faster than the refresh rate). Is > > > there any existing userspace that behaves this way that we can test > > > with? > > > > Hm, I've thought I've merged that patch already: > > > > commit ab58e3384b9f9863bfd029b458ff337d381bf6d2 > > Author: Daniel Vetter > > Date: Mon Nov 24 20:42:42 2014 +0100 > > > > drm/atomic-helper: Skip vblank waits for unchanged fbs > > > > Or is the problem here that the transitional plane helpers aren't up to > > the task? If so please reference that in your patch. > > > > And we still need a hack for the "changed fb cursor" issue, I'll whip > > something up. > > -Daniel > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > +41 (0) 79 365 57 48 - http://blog.ffwll.ch > > Just checking if anyone has come up with a fix. I am still stuck at > next-20150112 because of this bug. I've merged a patch from Matt Roper: commit d99b70ce7d73d78a88311453ccdd0fa0a670dd50 Author: Matt Roper Date: Mon Jan 19 08:31:49 2015 -0800 drm/plane-helper: Skip prepare_fb/cleanup_fb when newfb==oldfb that should rectify the sluggish i915 cursor. But it's in a separate topic branch which isn't in linux-next. Should show up in drm-next next week though. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch