All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	dri-devel@lists.freedesktop.org,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] drm: atmel-hlcdc: Add dependency on ARM
Date: Sat, 24 Jan 2015 18:15:00 +0100	[thread overview]
Message-ID: <20150124181500.43aca9cd@bbrezillon> (raw)
In-Reply-To: <54C2B29A.8010601@roeck-us.net>

Hi Guenter,

On Fri, 23 Jan 2015 12:44:10 -0800
Guenter Roeck <linux@roeck-us.net> wrote:

> On 01/23/2015 12:03 PM, Boris Brezillon wrote:
> > The atmel-hlcdc driver selects DRM_GEM_CMA_HELPER which makes use of
> > symbols only available when HAVE_DMA_ATTRS is selected.
> > Add a dependency on the ARM architecture which select this option.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > ---
> >   drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> > index 1a08562..99b4f06 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/Kconfig
> > +++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> > @@ -1,6 +1,6 @@
> >   config DRM_ATMEL_HLCDC
> >   	tristate "DRM Support for ATMEL HLCDC Display Controller"
> > -	depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC
> > +	depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && ARM
> 
> && HAVE_DMA_ATTRS
> 
> might have been a bit less restrictive.

Actually I greped HAVE_DMA_ATTRS in the kernel source tree and
apparently nobody directly depends on it, they all depend on one or
several architectures instead.

> Are you sure this controller
> is never used on any other architecture but arm, not even arm64 ?

Not that I know of, but maybe Nicolas can give some hints about the
upcoming Atmel ARM64 processors (or the long awaited Atmel AVR 64 bits
processor :-)).

More seriously, if Atmel ever decide to reuse this IP on a different
architecture, I think we'll add an '&& (ARM || XXX)' condition to the
depends on line.
> 
> Anyway, the xtensa:allmodconfig build is passing again with this patch
> applied, so
> 
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> 

Thanks for reporting the bug and testing the fix.

Best Regards,

Boris



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-01-24 17:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23  7:10 linux-next: Tree for Jan 23 Stephen Rothwell
2015-01-23 18:34 ` Guenter Roeck
2015-01-23 20:03   ` [PATCH] drm: atmel-hlcdc: Add dependency on ARM Boris Brezillon
2015-01-23 20:44     ` Guenter Roeck
2015-01-24 17:15       ` Boris Brezillon [this message]
2015-01-26  9:14         ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150124181500.43aca9cd@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux@roeck-us.net \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.