From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Dave Jiang <dave.jiang@intel.com>,
Nikhil Rao <nikhil.rao@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>
Subject: Re: [PATCH char-misc-next v2 01/13] misc: mic: SCIF header file and IOCTL interface
Date: Sun, 25 Jan 2015 20:41:00 +0800 [thread overview]
Message-ID: <20150125124100.GB21763@kroah.com> (raw)
In-Reply-To: <8ff5b107eeabad618e07c156ec541409b9f88c6a.1421097390.git.sudeep.dutt@intel.com>
On Mon, Jan 12, 2015 at 03:09:55PM -0800, Sudeep Dutt wrote:
> + * Errors:
> + * EBADF, ENOTTY
> + * epd is not a valid endpoint descriptor
> + * ECONNREFUSED
> + * The destination was not listening for connections or refused the
> + * connection request
> + * EINVAL
> + * epd is not a valid endpoint descriptor, or
> + * dst.port is not a valid port ID
> + * EISCONN
> + * The endpoint is already connected
> + * ENOMEM
> + * No buffer space is available
> + * ENODEV
> + * The destination node does not exist, or
> + * The node is lost or existed, but is not currently in the network since it
> + * may have crashed
> + * ENOSPC
> + * No port number available for assignment
> + * EOPNOTSUPP
> + * The endpoint is listening and cannot be connected
> +*/
Very odd formatting of these error codes here, and other places in this
.h file, please fix them all up and properly wrap your lines.
thanks,
greg k-h
next prev parent reply other threads:[~2015-01-25 16:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 23:09 [PATCH char-misc-next v2 00/13] misc: mic: SCIF driver Sudeep Dutt
2015-01-12 23:09 ` [PATCH char-misc-next v2 01/13] misc: mic: SCIF header file and IOCTL interface Sudeep Dutt
2015-01-25 12:39 ` Greg Kroah-Hartman
2015-01-26 18:07 ` Sudeep Dutt
2015-01-25 12:41 ` Greg Kroah-Hartman [this message]
2015-01-26 18:07 ` Sudeep Dutt
2015-01-12 23:09 ` [PATCH char-misc-next v2 02/13] misc: mic: SCIF ring buffer infrastructure Sudeep Dutt
2015-01-12 23:09 ` [PATCH char-misc-next v2 03/13] misc: mic: SCIF Hardware Bus Sudeep Dutt
2015-01-12 23:09 ` [PATCH char-misc-next v2 04/13] misc: mic: SCIF Peer Bus Sudeep Dutt
2015-01-12 23:09 ` [PATCH char-misc-next v2 05/13] misc: mic: Common MIC header file changes in preparation for SCIF Sudeep Dutt
2015-01-12 23:10 ` [PATCH char-misc-next v2 06/13] misc: mic: SCIF module initialization Sudeep Dutt
2015-01-12 23:10 ` [PATCH char-misc-next v2 07/13] misc: mic: SCIF node queue pair setup management Sudeep Dutt
2015-01-12 23:10 ` [PATCH char-misc-next v2 08/13] misc: mic: SCIF open close bind and listen APIs Sudeep Dutt
2015-01-12 23:10 ` [PATCH char-misc-next v2 09/13] misc: mic: SCIF connections APIs i.e. accept and connect Sudeep Dutt
2015-01-12 23:10 ` [PATCH char-misc-next v2 10/13] misc: mic: SCIF messaging and node enumeration APIs Sudeep Dutt
2015-01-12 23:10 ` [PATCH char-misc-next v2 11/13] misc: mic: MIC host driver specific changes to enable SCIF Sudeep Dutt
2015-01-12 23:10 ` [PATCH char-misc-next v2 12/13] misc: mic: MIC card " Sudeep Dutt
2015-01-12 23:10 ` [PATCH char-misc-next v2 13/13] misc: mic: add support for loading/unloading SCIF driver Sudeep Dutt
2015-01-25 12:44 ` [PATCH char-misc-next v2 00/13] misc: mic: " Greg Kroah-Hartman
2015-01-26 18:07 ` Sudeep Dutt
2015-01-26 20:27 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125124100.GB21763@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=ashutosh.dixit@intel.com \
--cc=corbet@lwn.net \
--cc=dave.jiang@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.rao@intel.com \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.