From: Al Viro <viro@ZenIV.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/5 v2] tracing: Automatically mount tracefs on debugfs/tracing
Date: Sun, 25 Jan 2015 20:31:15 +0000 [thread overview]
Message-ID: <20150125203115.GJ29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150125202729.GI29656@ZenIV.linux.org.uk>
On Sun, Jan 25, 2015 at 08:27:29PM +0000, Al Viro wrote:
> Turns out that it is better that way (and less prone to abuse). See
> vfs.git#debugfs_automount; some massage on top of 3.19-rc5, the payoff is
> in the last commit.
>
> For your code it's a matter of replacing struct path *path with void *unused
> in trace_automount() and just calling
> debugfs_create_automount("tracing", NULL, trace_automount, NULL);
> to create the sucker. That's it - no games with ->d_op, etc.
... and the total is plus 8 lines. Would be negative, if not for the
kerneldoc comment in there...
next prev parent reply other threads:[~2015-01-25 20:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 15:55 [PATCH 0/5 v2] tracing: Add new file system tracefs Steven Rostedt
2015-01-23 15:55 ` [PATCH 1/5 v2] tracefs: Add new tracefs file system Steven Rostedt
2015-01-23 15:55 ` [PATCH 2/5 v2] tracing: Convert the tracing facility over to use tracefs Steven Rostedt
2015-01-23 15:55 ` [PATCH 3/5 v2] tracing: Automatically mount tracefs on debugfs/tracing Steven Rostedt
2015-01-24 3:00 ` Greg Kroah-Hartman
2015-01-24 11:33 ` Steven Rostedt
2015-01-25 13:22 ` Greg Kroah-Hartman
2015-01-25 19:38 ` Steven Rostedt
2015-01-25 19:59 ` Al Viro
2015-01-25 20:27 ` Al Viro
2015-01-25 20:31 ` Al Viro [this message]
2015-01-23 15:55 ` [PATCH 4/5 v2] tracefs: Add directory /sys/kernel/tracing Steven Rostedt
2015-01-24 3:00 ` Greg Kroah-Hartman
2015-01-23 15:55 ` [PATCH 5/5 v2] tracing: Have mkdir and rmdir be part of tracefs Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125203115.GJ29656@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.