From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <maasami.hiramatsu.pt@hitachi.com>,
Vojtech Pavlik <vojtech@suse.cz>, Jiri Kosina <jkosina@suse.cz>,
Jiri Slaby <jslaby@suse.cz>,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>,
Dominik Vogt <vogt@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute
Date: Mon, 26 Jan 2015 16:26:00 +0100 [thread overview]
Message-ID: <20150126152600.GA6977@osiris> (raw)
In-Reply-To: <20150126102226.6f76b2ab@gandalf.local.home>
On Mon, Jan 26, 2015 at 10:22:26AM -0500, Steven Rostedt wrote:
> On Mon, 26 Jan 2015 16:03:19 +0100
> Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
>
> > Actually they should be mutually exclusive. I just merged them "just in case".
> >
> > So something like this
> >
> > #ifdef CC_USING_HOTPATCH
> > #define notrace __attribute__((hotpatch(0,0)))
> > #else
> > #define notrace __attribute__((no_instrument_function))
> > #endif
> >
> > will work as well (just tested).
>
> I think the above change looks cleaner.
Yes, I agree with you and will change the patch.
next prev parent reply other threads:[~2015-01-26 15:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 12:54 [PATCH/RFC 0/3] ftrace: allow arch specific compile options Heiko Carstens
2015-01-26 12:54 ` [PATCH/RFC 1/3] ftrace: allow architectures to specify ftrace " Heiko Carstens
2015-01-26 12:54 ` [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute Heiko Carstens
2015-01-26 14:37 ` Steven Rostedt
2015-01-26 15:03 ` Heiko Carstens
2015-01-26 15:22 ` Steven Rostedt
2015-01-26 15:26 ` Heiko Carstens [this message]
2015-01-27 6:19 ` Dominik Vogt
2015-01-27 14:42 ` Steven Rostedt
2015-01-28 5:36 ` Heiko Carstens
2015-01-28 11:57 ` Steven Rostedt
2015-01-28 12:18 ` Heiko Carstens
2015-01-28 12:38 ` Steven Rostedt
2015-01-26 12:54 ` [PATCH/RFC 3/3] s390/ftrace: hotpatch support for function tracing Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126152600.GA6977@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=jkosina@suse.cz \
--cc=jslaby@suse.cz \
--cc=krebbel@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maasami.hiramatsu.pt@hitachi.com \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
--cc=vogt@linux.vnet.ibm.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.