From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YFmsT-0000Iy-KA for mharc-grub-devel@gnu.org; Mon, 26 Jan 2015 11:51:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFmsL-00007u-Lt for grub-devel@gnu.org; Mon, 26 Jan 2015 11:51:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFmsI-0000Se-F8 for grub-devel@gnu.org; Mon, 26 Jan 2015 11:50:57 -0500 Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]:65172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFmsI-0000SR-6c for grub-devel@gnu.org; Mon, 26 Jan 2015 11:50:54 -0500 Received: by mail-lb0-f180.google.com with SMTP id b6so8530682lbj.11 for ; Mon, 26 Jan 2015 08:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=Ek6OFXYyYJuScTGCDWrAmlYUNrtgHwonWN9ZNlAbdNg=; b=UaxvflR+dKt+9/rtZbiCqaZP0jnIR8Jn2+Z+W8y8pZ9+uYbGQHG4R588XzNTYnFM9v vXA0A367p4DAlNHYERg5MhyGghkd9SQ6oZTjAKCbfMHwHKDj9Rud2WxE4kRMshgbXK7g 9cxXzijpLV7wGW0IdZM7REy3U9zgZ/gWcEbihYPZNqbz6ls8RrvgFi/MElxSlQuHgbvt 3Y/3yr9JMejNLVfWbB11SIXvo5ccdTERgDz8aPJiyCgNa+wMKsppuZRCCUfrLNPMhxH4 B7FiLi64iivmPOHElqE/Fzt6atOYQbERZMGNKvLdSnewrIzCs6hdfuUMjEFKWAeoapXk u6Gg== X-Received: by 10.152.22.67 with SMTP id b3mr22538092laf.82.1422291053193; Mon, 26 Jan 2015 08:50:53 -0800 (PST) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id jg8sm2933093lbc.0.2015.01.26.08.50.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jan 2015 08:50:52 -0800 (PST) Date: Mon, 26 Jan 2015 19:50:50 +0300 From: Andrei Borzenkov To: The development of GNU GRUB Subject: Re: configure.ac: Always add -D_FILE_OFFSET_BITS=64. Message-ID: <20150126195050.13f6969a@opensuse.site> In-Reply-To: References: <54C65779.3070500@gmail.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2015 16:51:03 -0000 =D0=92 Mon, 26 Jan 2015 18:12:19 +0300 Andrei Borzenkov =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Mon, Jan 26, 2015 at 6:04 PM, Vladimir '=CF=86-coder/phcoder' Serbinen= ko > wrote: > > On 26.01.2015 12:29, Andrei Borzenkov wrote: > >>> +CPPFLAGS=3D"$CPPFLAGS -D_FILE_OFFSET_BITS=3D64" > >>> +HOST_CPPFLAGS=3D"$HOST_CPPFLAGS -D_FILE_OFFSET_BITS=3D64" > >> > >> > >> We already have them unconditionally in config.h. This is confusing; > >> may be remove them from this file. OTOH we have AC_LARGEFILES that is > >> expected to figure out proper options (although I believe for now > >> there is just one system that needs it). > >> > > Do you mean AC_SYS_LARGEFILE ? Does it actually work? >=20 > It apparently works for other projects ... >=20 > > = How exactly does > > it make its way to HOST_CPPFLAGS? >=20 > It does not, that is my point. Sorry, was wrong. It makes it way via config-util.h AC_CONFIG_HEADER([config-util.h]) and=20 /* Number of bits in a file offset, on hosts where this is settable. */ /* #undef _FILE_OFFSET_BITS */ /* Define for large files, on AIX-style hosts. */ /* #undef _LARGE_FILES */ I'm on 64 bit Linux so do not need any of these to enable large files. So your patch seems to be redundant and I'd consider removing them from config.h as well after release. > We uncoditionally force both known > knobs statically in config.h. I'm fine with forcing it in configure > (then at least check for sizeof(off_t) will match what we have at > compilation time) but then they must be removed from config.h. >=20 > But yes, for now AC_SYS_LARGEFILE is pretty much useless here. >=20 > >> > >> This all looks rather messy. > >> > >> _______________________________________________ > >> Grub-devel mailing list > >> Grub-devel@gnu.org > >> https://lists.gnu.org/mailman/listinfo/grub-devel > >> > > > > > > > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel > >