From: Bjorn <bjorn@sonymobile.com>
To: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Joonwoo Park <joonwoop@codeaurora.org>
Subject: Re: [PATCH 3/3] pinctrl: qcom: Add msm8916 pinctrl driver
Date: Tue, 27 Jan 2015 09:31:08 -0800 [thread overview]
Message-ID: <20150127173107.GE11960@sonymobile.com> (raw)
In-Reply-To: <1421745476-6276-4-git-send-email-svarbanov@mm-sol.com>
On Tue 20 Jan 01:17 PST 2015, Stanimir Varbanov wrote:
> From: Joonwoo Park <joonwoop@codeaurora.org>
>
> Add initial pinctrl driver to support pin configuration with
> pinctrl framework for msm8916.
>
> Signed-off-by: Joonwoo Park <joonwoop@codeaurora.org>
> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
> ---
[..]
> +
> +static const struct msm_pingroup msm8916_groups[] = {
> + PINGROUP(0, blsp_spi1, blsp_uart1, blsp_uim1, dmic0_clk, NA, NA, NA, NA,
> + NA),
It's totally okay not to line break these things...
> + PINGROUP(1, blsp_spi1, blsp_uart1, blsp_uim1, dmic0_data, NA, NA, NA,
> + NA, NA),
> + PINGROUP(2, blsp_spi1, blsp_uart1, blsp_i2c1, NA, NA, NA, NA, NA, NA),
[..]
> +};
> +
[..]
My documentation is lacking the pingroup table, the rest is:
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Regards,
Bjorn
next prev parent reply other threads:[~2015-01-27 17:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 9:17 [PATCH 0/3] pinctrl: Qualcomm msm8916 pinctrl driver Stanimir Varbanov
2015-01-20 9:17 ` [PATCH 1/3] pinctrl: qcom: increase variable size for register addresses Stanimir Varbanov
2015-01-27 16:59 ` Bjorn
2015-01-20 9:17 ` [PATCH 2/3] DT: pinctrl: Document Qualcomm MSM8916 pinctrl binding Stanimir Varbanov
2015-01-27 17:20 ` Bjorn
2015-01-20 9:17 ` [PATCH 3/3] pinctrl: qcom: Add msm8916 pinctrl driver Stanimir Varbanov
2015-01-27 17:31 ` Bjorn [this message]
[not found] ` <1421745476-6276-4-git-send-email-svarbanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2015-01-28 23:18 ` Andy Gross
2015-01-28 23:18 ` Andy Gross
2015-01-29 14:27 ` Stanimir Varbanov
2015-01-21 16:43 ` [PATCH 0/3] pinctrl: Qualcomm " Linus Walleij
2015-01-21 16:43 ` Linus Walleij
2015-01-27 13:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127173107.GE11960@sonymobile.com \
--to=bjorn@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joonwoop@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.