From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 28 Jan 2015 06:43:35 +0000 Subject: [patch] drm/bridge: checking the wrong variable Message-Id: <20150128064335.GC30893@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Airlie Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org We were supposed to check "fmts" here instead of "formats". I suppose it eventually leads to a NULL dereference. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 98fb640..8ae239f 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -783,7 +783,7 @@ int drm_display_info_set_bus_formats(struct drm_display_info *info, if (formats && num_formats) { fmts = kmemdup(formats, sizeof(*formats) * num_formats, GFP_KERNEL); - if (!formats) + if (!fmts) return -ENOMEM; } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/bridge: checking the wrong variable Date: Wed, 28 Jan 2015 09:43:35 +0300 Message-ID: <20150128064335.GC30893@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B7436E62A for ; Tue, 27 Jan 2015 22:43:55 -0800 (PST) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org V2Ugd2VyZSBzdXBwb3NlZCB0byBjaGVjayAiZm10cyIgaGVyZSBpbnN0ZWFkIG9mICJmb3JtYXRz Ii4gIEkgc3VwcG9zZQppdCBldmVudHVhbGx5IGxlYWRzIHRvIGEgTlVMTCBkZXJlZmVyZW5jZS4K ClNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4K CmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fY3J0Yy5jCmluZGV4IDk4ZmI2NDAuLjhhZTIzOWYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fY3J0Yy5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCkBAIC03 ODMsNyArNzgzLDcgQEAgaW50IGRybV9kaXNwbGF5X2luZm9fc2V0X2J1c19mb3JtYXRzKHN0cnVj dCBkcm1fZGlzcGxheV9pbmZvICppbmZvLAogCWlmIChmb3JtYXRzICYmIG51bV9mb3JtYXRzKSB7 CiAJCWZtdHMgPSBrbWVtZHVwKGZvcm1hdHMsIHNpemVvZigqZm9ybWF0cykgKiBudW1fZm9ybWF0 cywKIAkJCSAgICAgICBHRlBfS0VSTkVMKTsKLQkJaWYgKCFmb3JtYXRzKQorCQlpZiAoIWZtdHMp CiAJCQlyZXR1cm4gLUVOT01FTTsKIAl9CiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK