From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Wed, 28 Jan 2015 07:59:17 +0000 Subject: Re: [patch] drm/bridge: checking the wrong variable Message-Id: <20150128075915.GA23469@ulmo> MIME-Version: 1 Content-Type: multipart/mixed; boundary="zhXaljGHf11kAtnf" List-Id: References: <20150128064335.GC30893@mwanda> In-Reply-To: To: Daniel Kurtz Cc: kernel-janitors@vger.kernel.org, dri-devel , Dan Carpenter --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 28, 2015 at 02:46:46PM +0800, Daniel Kurtz wrote: > Hi Dan, >=20 > nit: this patch is not really for "drm/bridge". >=20 > On Wed, Jan 28, 2015 at 2:43 PM, Dan Carpenter = wrote: > > > > We were supposed to check "fmts" here instead of "formats". I suppose > > it eventually leads to a NULL dereference. > > > > Signed-off-by: Dan Carpenter > > >=20 > Otherwise, good catch! >=20 > Reviewed-by: Daniel Kurtz I've reworded the commit message slightly and applied this. Thanks. Thierry --zhXaljGHf11kAtnf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUyJbTAAoJEN0jrNd/PrOhKR0P/19jT5hgxTZ5YP6uO6/I1Eic QpiN9ao41ImAW82XOLTn5OWs02F2X7QyWogQXHIC6aasadjQKJlQr0H3HLFWgcBk jJwuTVEUlu0TgFeqSu1ryR9tFjUF8+Dy+IQPiOENe5EqfU/leysj49jwC1yacc39 k7do+l8OE9hnm5vOPmkFJcMzkgqwOFrkywPCqujh+sHmFjMty9YZ+VX6uNj4VaVh L/VYGqLQF1R9PFLT57u71cYf54wKigw35zfCJhvrLLbjQJvNJi0YAF+wt0Gx0fUG cj5d9k1tHwrmcoWsiuMSkif2VF2xnGXYv4c8sB+XD9VGpbg6I2UuqvIvZnc6FXwj eLIIQwvxShCgMOz6hFtWDpkhEgR5R+H67QzazdPA8lJdKS2cAa6davXhfqcP/4nM XIHPay9Pe8Yh2qrI96bUpBryvFlUU2y1REV3XC6iwRQ1EChO6xK5HLdDzKZQUa6P u/Pg+OVS6EjXxnEmeYm3ZXudhWYBiA1oe4+KFJT0NTLNtqq06jMUXppsaYhyMY+C kSGQznzbQFa/MJcQDqtT5MA1YVhdF/2muOl9TeWqHaGeo5GfjrZ2I/9nUvWUsnum IhrY1w5hzloyMnwD/fhqQ15aGwAcxhL5SUoNhbVLxShojTrE/Pvs6XWQDcWp1DNS spgQSOfJdM55P68iAsvu =EIlL -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [patch] drm/bridge: checking the wrong variable Date: Wed, 28 Jan 2015 08:59:17 +0100 Message-ID: <20150128075915.GA23469@ulmo> References: <20150128064335.GC30893@mwanda> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1443799260==" Return-path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 43CDC6E3EF for ; Tue, 27 Jan 2015 23:59:20 -0800 (PST) Received: by mail-we0-f170.google.com with SMTP id w55so13756241wes.1 for ; Tue, 27 Jan 2015 23:59:19 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Kurtz Cc: kernel-janitors@vger.kernel.org, dri-devel , Dan Carpenter List-Id: dri-devel@lists.freedesktop.org --===============1443799260== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zhXaljGHf11kAtnf" Content-Disposition: inline --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 28, 2015 at 02:46:46PM +0800, Daniel Kurtz wrote: > Hi Dan, >=20 > nit: this patch is not really for "drm/bridge". >=20 > On Wed, Jan 28, 2015 at 2:43 PM, Dan Carpenter = wrote: > > > > We were supposed to check "fmts" here instead of "formats". I suppose > > it eventually leads to a NULL dereference. > > > > Signed-off-by: Dan Carpenter > > >=20 > Otherwise, good catch! >=20 > Reviewed-by: Daniel Kurtz I've reworded the commit message slightly and applied this. Thanks. Thierry --zhXaljGHf11kAtnf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUyJbTAAoJEN0jrNd/PrOhKR0P/19jT5hgxTZ5YP6uO6/I1Eic QpiN9ao41ImAW82XOLTn5OWs02F2X7QyWogQXHIC6aasadjQKJlQr0H3HLFWgcBk jJwuTVEUlu0TgFeqSu1ryR9tFjUF8+Dy+IQPiOENe5EqfU/leysj49jwC1yacc39 k7do+l8OE9hnm5vOPmkFJcMzkgqwOFrkywPCqujh+sHmFjMty9YZ+VX6uNj4VaVh L/VYGqLQF1R9PFLT57u71cYf54wKigw35zfCJhvrLLbjQJvNJi0YAF+wt0Gx0fUG cj5d9k1tHwrmcoWsiuMSkif2VF2xnGXYv4c8sB+XD9VGpbg6I2UuqvIvZnc6FXwj eLIIQwvxShCgMOz6hFtWDpkhEgR5R+H67QzazdPA8lJdKS2cAa6davXhfqcP/4nM XIHPay9Pe8Yh2qrI96bUpBryvFlUU2y1REV3XC6iwRQ1EChO6xK5HLdDzKZQUa6P u/Pg+OVS6EjXxnEmeYm3ZXudhWYBiA1oe4+KFJT0NTLNtqq06jMUXppsaYhyMY+C kSGQznzbQFa/MJcQDqtT5MA1YVhdF/2muOl9TeWqHaGeo5GfjrZ2I/9nUvWUsnum IhrY1w5hzloyMnwD/fhqQ15aGwAcxhL5SUoNhbVLxShojTrE/Pvs6XWQDcWp1DNS spgQSOfJdM55P68iAsvu =EIlL -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf-- --===============1443799260== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1443799260==--