From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm: bridge/dw_hdmi: Fix return error path Date: Wed, 28 Jan 2015 09:00:53 +0100 Message-ID: <20150128080052.GB23469@ulmo> References: <1422363252-7156-1-git-send-email-fabio.estevam@freescale.com> <1422371871.3751.55.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0144724232==" Return-path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 4558D6E632 for ; Wed, 28 Jan 2015 00:00:56 -0800 (PST) Received: by mail-we0-f173.google.com with SMTP id w62so19209272wes.4 for ; Wed, 28 Jan 2015 00:00:55 -0800 (PST) In-Reply-To: <1422371871.3751.55.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: Fabio Estevam , andy.yan@rock-chips.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0144724232== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IiVenqGWf+H9Y6IX" Content-Disposition: inline --IiVenqGWf+H9Y6IX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 27, 2015 at 04:17:51PM +0100, Philipp Zabel wrote: > Hi Fabio, >=20 > Am Dienstag, den 27.01.2015, 10:54 -0200 schrieb Fabio Estevam: > > If devm_request_threaded_irq() fails we should jump to 'err_iahb' label= that=20 > > will disable the clocks that were previously enabled. > >=20 > > Signed-off-by: Fabio Estevam > > --- > > drivers/gpu/drm/bridge/dw_hdmi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/= dw_hdmi.c > > index ed3dfe7..cd6a706 100644 > > --- a/drivers/gpu/drm/bridge/dw_hdmi.c > > +++ b/drivers/gpu/drm/bridge/dw_hdmi.c > > @@ -1642,7 +1642,7 @@ int dw_hdmi_bind(struct device *dev, struct devic= e *master, > > dw_hdmi_irq, IRQF_SHARED, > > dev_name(dev), hdmi); > > if (ret) > > - return ret; > > + goto err_iahb; > > =20 > > /* > > * To prevent overflows in HDMI_IH_FC_STAT2, set the clk regenerator >=20 > Thanks for the fix. I have applied this to my tree since I've introduced > the bug in there. I'm currently redoing the drm/{panel,bridge} pull request anyway, so I could apply this while at it. Thierry --IiVenqGWf+H9Y6IX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUyJc0AAoJEN0jrNd/PrOhrrMP/RncBm/+1aiJN7nZSd3xO9Ud iEcmAKFAdWv4XYMzusk57F0sGnV6Ku6vLvk03ytjGVFWdq8KIqUzBEDQdhYG0UEO 8rbHGwzLHGCiWmbNbuaEvZMkI5nyl/XzakoZCxoe6308oJ8icWYxpUIRDSRaUnfR t15jZ8qjWBN9HRMnE5UMTIbDqzXpwk/cs4KbqtIy66qdxPqYs+DcIMQHD7tfzDy3 Jn3Xb/DeWYZuOYuZkCYVPhp7Zedw5YwgUM+6OcJg5uiPl+aBkh1+HE7E3hZwjHms +T7uU0m0CvGez/sI7T4zspOAJisz7hBKKP+CYi6Yz17RIDIf2pNJc8lN8cOLUmXq quvOrHb3DsXqvSalw+Q2fGxdkQZGgN/751TM/f5Kph2GP83czW+KDnZMgJJs8byj bUjyjMzgYmx9RVXD0pQNXMEp9uHXkJ8MhFSPZtygwNMFZeInnb8Jc/O90SBB1ZiV ZiaFFHN+Z6f7zy3OQ2oAuxa1GGeuGnDvgy4NEplbK3sueUDG66rF65ziXib6157q V7O1PfcL10N/F2OQHuas1QlTy4T2f3irW4R3iewBwaRbeAoy5jZq/1P670s3oO2w 8yv6t9mMIZtFUmpn4LOIgBv6zOOr98dgLGbpxoJtSoH6/GsEdIJ8W8SkxQRwLbVi q/75nkD6RXkEvkJFfzG1 =LLys -----END PGP SIGNATURE----- --IiVenqGWf+H9Y6IX-- --===============0144724232== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0144724232==--