From: Borislav Petkov <bp@alien8.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
james@dingwall.me.uk, stable@vger.kernel.org.#.3.18
Subject: Re: [PATCH] x86, microcode: Return error from driver init code when loader is disabled
Date: Wed, 28 Jan 2015 12:06:34 +0100 [thread overview]
Message-ID: <20150128110634.GG12929@pd.tnic> (raw)
In-Reply-To: <1422411669-25147-1-git-send-email-boris.ostrovsky@oracle.com>
On Tue, Jan 27, 2015 at 09:21:09PM -0500, Boris Ostrovsky wrote:
> Commits 65cef1311d5d ("x86, microcode: Add a disable chicken bit") and
> a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on
> paravirt") allow microcode driver skip initialization when microcode
> loading is not permitted.
>
> However, they don't prevent the driver from being loaded since the
> init code returns 0. If at some point later the driver gets unloaded
> this will result in an oops while trying to deregister the (never
> registered) device.
>
> To avoid this, make init code return an error on paravirt or when
> microcode loading is disabled. The driver will then never be loaded.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Reported-by: James Digwall <james@dingwall.me.uk>
> Cc: stable@vger.kernel.org # 3.18
Applied, thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-01-28 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 2:21 [PATCH] x86, microcode: Return error from driver init code when loader is disabled Boris Ostrovsky
2015-01-28 11:06 ` Borislav Petkov [this message]
2015-01-29 6:54 ` [tip:x86/urgent] " tip-bot for Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128110634.GG12929@pd.tnic \
--to=bp@alien8.de \
--cc=boris.ostrovsky@oracle.com \
--cc=james@dingwall.me.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org.#.3.18 \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.