From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] posix_acl: fix reference leaks in posix_acl_create Date: Wed, 28 Jan 2015 18:09:52 +0100 Message-ID: <20150128170952.GB17528@lst.de> References: <0d8672e771b8fc1fef94db4b40b418afc8763c2b.1422338890.git.osandov@osandov.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Omar Sandoval Return-path: Content-Disposition: inline In-Reply-To: <0d8672e771b8fc1fef94db4b40b418afc8763c2b.1422338890.git.osandov@osandov.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Jan 26, 2015 at 10:16:53PM -0800, Omar Sandoval wrote: > get_acl gets a reference which we must release in the error cases. > > Signed-off-by: Omar Sandoval Looks good, but at this point goto-based unwinding might be in order.