From: Greg KH <gregkh@linuxfoundation.org>
To: Heba Aamer <heba93aamer@gmail.com>
Cc: devel@driverdev.osuosl.org, noralf@tronnes.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: fbtft: fix Macros with complex values should be enclosed in parentheses
Date: Wed, 28 Jan 2015 11:28:21 -0800 [thread overview]
Message-ID: <20150128192821.GA3213@kroah.com> (raw)
In-Reply-To: <8dfee4846d30defff32f46d4322979b33c2fa33b.1422443132.git.heba93aamer@gmail.com>
On Wed, Jan 28, 2015 at 01:19:25PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl error:
> fix Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
> ---
> drivers/staging/fbtft/fb_pcd8544.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index 678ab8e..87ca96e 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -33,7 +33,7 @@
> #define DRVNAME "fb_pcd8544"
> #define WIDTH 84
> #define HEIGHT 48
> -#define TXBUFLEN 84*6
> +#define TXBUFLEN (84*6)
> #define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this driver */
>
> static unsigned tc = 0;
This is already in my tree, did you redo this series and not say a 'v2'
in them?
confused,
greg k-h
next prev parent reply other threads:[~2015-01-28 20:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 11:16 [PATCH 0/5] Fix fbtft/fb_pcd8544.c coding style errors and warnings Heba Aamer
2015-01-28 11:19 ` [PATCH 1/5] staging: fbtft: fix Macros with complex values should be enclosed in parentheses Heba Aamer
2015-01-28 19:28 ` Greg KH [this message]
2015-01-28 11:21 ` [PATCH 2/5] staging: fbtft: fix do not initialise statics to 0 or NULL Heba Aamer
2015-01-28 11:24 ` [PATCH 3/5] staging: fbtft: fix horizontal spaces errors Heba Aamer
2015-01-28 11:26 ` [PATCH 4/5] staging: fbtft: fix trailing whitespace Heba Aamer
2015-01-28 11:28 ` [PATCH 5/5] staging: fbtft: fix braces {} are not necessary for single statement blocks Heba Aamer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128192821.GA3213@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=heba93aamer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.