From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Parrot Subject: Re: [PATCH v2] ARM: AM43xx: hwmod: add VPFE hwmod entries Date: Wed, 28 Jan 2015 13:30:38 -0600 Message-ID: <20150128193038.GG2570@ti.com> References: <1422217915-24231-1-git-send-email-prabhakar.csengg@gmail.com> <20150126155032.GD2570@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Paul Walmsley Cc: Tony Lindgren , LKML , Felipe Balbi , Darren Etheridge , "Lad, Prabhakar" , Linux OMAP Mailing List , LAK List-Id: linux-omap@vger.kernel.org UGF1bCBXYWxtc2xleSA8cGF1bEBwd3Nhbi5jb20+IHdyb3RlIG9uIE1vbiBbMjAxNS1KYW4tMjYg MTg6NDc6MTEgKzAwMDBdOgo+IEhpIFByYWJoYWthciwKPiAKPiBPbiBNb24sIDI2IEphbiAyMDE1 LCBMYWQsIFByYWJoYWthciB3cm90ZToKPiAKPiA+IEhpIEJlbm9pdCwKPiA+IAo+ID4gT24gTW9u LCBKYW4gMjYsIDIwMTUgYXQgMzo1MCBQTSwgQmVub2l0IFBhcnJvdCA8YnBhcnJvdEB0aS5jb20+ IHdyb3RlOgo+ID4gPiBMYWQsIFByYWJoYWthciA8cHJhYmhha2FyLmNzZW5nZ0BnbWFpbC5jb20+ IHdyb3RlIG9uIE1vbiBbMjAxNS1KYW4tMjYgMDg6MTM6MDEgKzAwMDBdOgo+ID4gPj4gSGkgUGF1 bCwKPiA+ID4+Cj4gPiA+PiBUaGFua3MgZm9yIHRoZSByZXZpZXcuCj4gPiA+Pgo+ID4gPj4gT24g TW9uLCBKYW4gMjYsIDIwMTUgYXQgMjoxNSBBTSwgUGF1bCBXYWxtc2xleSA8cGF1bEBwd3Nhbi5j b20+IHdyb3RlOgo+ID4gPj4gPiBIaQo+ID4gPj4gPgo+ID4gPj4gPiBPbiBTdW4sIDI1IEphbiAy MDE1LCBMYWQsIFByYWJoYWthciB3cm90ZToKPiA+ID4+ID4KPiA+ID4+ID4+IEZyb206IEJlbm9p dCBQYXJyb3QgPGJwYXJyb3RAdGkuY29tPgo+ID4gPj4gPj4KPiA+ID4+ID4+IHRoaXMgcGF0Y2gg YWRkcyBWUEZFIEhXTU9EIGRhdGEgZm9yIEFNNDN4eC4KPiA+ID4+ID4+Cj4gPiA+PiA+PiBTaWdu ZWQtb2ZmLWJ5OiBCZW5vaXQgUGFycm90IDxicGFycm90QHRpLmNvbT4KPiA+ID4+ID4+IFNpZ25l ZC1vZmYtYnk6IERhcnJlbiBFdGhlcmlkZ2UgPGRldGhlcmlkZ2VAdGkuY29tPgo+ID4gPj4gPj4g U2lnbmVkLW9mZi1ieTogRmVsaXBlIEJhbGJpIDxiYWxiaUB0aS5jb20+Cj4gPiA+PiA+PiBTaWdu ZWQtb2ZmLWJ5OiBMYWQsIFByYWJoYWthciA8cHJhYmhha2FyLmNzZW5nZ0BnbWFpbC5jb20+Cj4g PiA+PiA+PiAtLS0KPiA+ID4+ID4+ICBIaSBQYXVsLAo+ID4gPj4gPj4KPiA+ID4+ID4+ICBZb3Ug d2VyZSByaWdodCwgdGhlIGhhcmR3YXJlIHRlYW0gaGFzIGNvbmZpcm1lZCB0aGF0LCB0aGUgVlBG RSBtYXN0ZXIgcG9ydCBpcwo+ID4gPj4gPj4gIGNvbm5lY3RlZCB0byBMMyBhbmQgdGhlIFZQRkUg c2xhdmUgcG9ydCBpcyBjb25uZWN0ZWQgdG8gTDQuIFRoZSBMMyBwb3J0IGNhbm5vdAo+ID4gPj4g Pj4gIHNlcnZlIGFzIGEgcmVnaXN0ZXIgdGFyZ2V0IGJlY2F1c2UgaXQgaXMgaW5pdGlhdG9yIG9u bHkuCj4gPiA+PiA+Cj4gPiA+PiA+IE9LIG1ha2VzIHNlbnNlIHRvIG1lLiwKPiA+ID4+ID4KPiA+ ID4+ID4+Cj4gPiA+PiA+PiAgSSBoYXZlIGNyZWF0ZWQgbGlua3MgcmVmZXJyaW5nIHRvIGRzcyBs My9sNCBod21vZCBhbmQgdGVzdGVkIGl0LCBsZW1tZSBrbm93Cj4gPiA+PiA+PiAgaWYgSSBoYXZl IG1pc3NlZCBzb21ldGhpbmcuCj4gPiA+PiA+Cj4gPiA+PiA+IEEgZmV3IG1pbm9yIGNvbW1lbnRz IGJlbG93Cj4gPiA+PiA+Cj4gPiA+PiA+Pgo+ID4gPj4gW1NuaXBdCj4gPiA+PiA+PiAgLyogSW50 ZXJmYWNlcyAqLwo+ID4gPj4gPj4gIHN0YXRpYyBzdHJ1Y3Qgb21hcF9od21vZF9vY3BfaWYgYW00 M3h4X2wzX21haW5fX2w0X2hzID0gewo+ID4gPj4gPj4gICAgICAgLm1hc3RlciAgICAgICAgID0g JmFtMzN4eF9sM19tYWluX2h3bW9kLAo+ID4gPj4gPj4gQEAgLTc4OCw2ICs4MjYsMzYgQEAgc3Rh dGljIHN0cnVjdCBvbWFwX2h3bW9kX29jcF9pZiBhbTQzeHhfbDRfbHNfX2Rzc19yZmJpID0gewo+ ID4gPj4gPj4gICAgICAgLnVzZXIgICAgICAgICAgID0gT0NQX1VTRVJfTVBVIHwgT0NQX1VTRVJf U0RNQSwKPiA+ID4+ID4+ICB9Owo+ID4gPj4gPj4KPiA+ID4+ID4+ICtzdGF0aWMgc3RydWN0IG9t YXBfaHdtb2Rfb2NwX2lmIGFtNDN4eF9sM19fdnBmZTAgPSB7Cj4gPiA+PiA+PiArICAgICAubWFz dGVyICAgICAgICAgPSAmYW00M3h4X3ZwZmUwX2h3bW9kLAo+ID4gPj4gPj4gKyAgICAgLnNsYXZl ICAgICAgICAgID0gJmFtMzN4eF9sM19tYWluX2h3bW9kLAo+ID4gPj4gPj4gKyAgICAgLmNsayAg ICAgICAgICAgID0gImwzX2djbGsiLAo+ID4gPj4gPj4gKyAgICAgLmZsYWdzICAgICAgICAgID0g T0NQSUZfU1dTVVBfSURMRSwKPiA+ID4+ID4KPiA+ID4+ID4gT0NQSUZfU1dTVVBfSURMRSBwcm9i YWJseSBpc24ndCBuZWVkZWQgaGVyZS4gIENvdWxkIHlvdSBwbGVhc2UgdHJ5IHdpdGhvdXQKPiA+ ID4+ID4gaXQ/Cj4gPiA+PiA+Cj4gPiA+PiA+PiArICAgICAudXNlciAgICAgICAgICAgPSBPQ1Bf VVNFUl9NUFUgfCBPQ1BfVVNFUl9TRE1BLAo+ID4gPj4gPj4gK307Cj4gPiA+PiA+PiArCj4gPiA+ PiA+PiArc3RhdGljIHN0cnVjdCBvbWFwX2h3bW9kX29jcF9pZiBhbTQzeHhfbDNfX3ZwZmUxID0g ewo+ID4gPj4gPj4gKyAgICAgLm1hc3RlciAgICAgICAgID0gJmFtNDN4eF92cGZlMV9od21vZCwK PiA+ID4+ID4+ICsgICAgIC5zbGF2ZSAgICAgICAgICA9ICZhbTMzeHhfbDNfbWFpbl9od21vZCwK PiA+ID4+ID4+ICsgICAgIC5jbGsgICAgICAgICAgICA9ICJsM19nY2xrIiwKPiA+ID4+ID4+ICsg ICAgIC5mbGFncyAgICAgICAgICA9IE9DUElGX1NXU1VQX0lETEUsCj4gPiA+PiA+Cj4gPiA+PiA+ IFNhbWUgcG9pbnQgYXMgdGhlIGFib3ZlLgo+ID4gPj4gPgo+ID4gPj4gRHJvcHBlZCBhbmQgdGVz dGVkIHdvcmtzISBwb3N0aW5nIGEgdjMuCj4gPiA+Cj4gPiA+IFdoZW4geW91IHRlc3RlZCBpdCB3 aXRob3V0IHRoZSBPQ1BJRl9TV1NVUF9JRExFLCBkaWQgeW91IGdvIHRyaG91Z2ggYSBjb21wbGV0 ZSBzdXNwZW5kL3Jlc3VtZSBjeWNsZT8KPiA+ID4gVGhpcyBmbGFnIHdhcyBhZGRlZCBlYXJseSBv biBiZWNhdXNlIG90aGVyd2lzZSB0aGUgc3VzYnN5dGVtIHdvdWxkIG5vdCBnbyBpZGxlIHdpdGhv dXQgaXQuLi4KPiA+ID4KPiA+ID4gQ2FuIHlvdSBwb3N0IHRoZSBjb25zb2xlIG91dHB1dCBkdXJp bmcgYSBzdXNwZW5kL3Jlc3VtZSBjeWNsZT8KPiA+ID4KPiA+IEFoIEkgZGlkbuKAmXQgdGVzdCB0 aGUgc3VzcGVuZC9yZXN1bWUgd2lsbCBkbyBhbmQgcG9zdCB0aGUgY29uc29sZSBsb2cuCj4gCj4g Q291bGQgeW91IGFsc28gZG8gYSBzdXNwZW5kL3Jlc3VtZSB0ZXN0IG9uIHYyPwoKUHJhYmJoYWth ciwKCkkgdGVzdGVkIGJvdGggdjIgYW5kIHYzIGFuZCBib3RoIHN1Y2Nlc3NmdWxseSB3ZW50IHRo cm91Z2ggYSBzdXNwZW5kL3Jlc3VtZSBjeWNsZS4KU28gSSBndWVzcyB2MyBpcyBmaW5lLCBzb3Jy eSBmb3IgdGhlIG5vaXNlLgoKSSdsbCBhZGQgYSB0ZXN0ZWQtYnkgb24gVjMuCgpCZW5vaXQKCj4g IAo+IHRoYW5rcwo+IAo+IC0gUGF1bAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: bparrot@ti.com (Benoit Parrot) Date: Wed, 28 Jan 2015 13:30:38 -0600 Subject: [PATCH v2] ARM: AM43xx: hwmod: add VPFE hwmod entries In-Reply-To: References: <1422217915-24231-1-git-send-email-prabhakar.csengg@gmail.com> <20150126155032.GD2570@ti.com> Message-ID: <20150128193038.GG2570@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Paul Walmsley wrote on Mon [2015-Jan-26 18:47:11 +0000]: > Hi Prabhakar, > > On Mon, 26 Jan 2015, Lad, Prabhakar wrote: > > > Hi Benoit, > > > > On Mon, Jan 26, 2015 at 3:50 PM, Benoit Parrot wrote: > > > Lad, Prabhakar wrote on Mon [2015-Jan-26 08:13:01 +0000]: > > >> Hi Paul, > > >> > > >> Thanks for the review. > > >> > > >> On Mon, Jan 26, 2015 at 2:15 AM, Paul Walmsley wrote: > > >> > Hi > > >> > > > >> > On Sun, 25 Jan 2015, Lad, Prabhakar wrote: > > >> > > > >> >> From: Benoit Parrot > > >> >> > > >> >> this patch adds VPFE HWMOD data for AM43xx. > > >> >> > > >> >> Signed-off-by: Benoit Parrot > > >> >> Signed-off-by: Darren Etheridge > > >> >> Signed-off-by: Felipe Balbi > > >> >> Signed-off-by: Lad, Prabhakar > > >> >> --- > > >> >> Hi Paul, > > >> >> > > >> >> You were right, the hardware team has confirmed that, the VPFE master port is > > >> >> connected to L3 and the VPFE slave port is connected to L4. The L3 port cannot > > >> >> serve as a register target because it is initiator only. > > >> > > > >> > OK makes sense to me., > > >> > > > >> >> > > >> >> I have created links referring to dss l3/l4 hwmod and tested it, lemme know > > >> >> if I have missed something. > > >> > > > >> > A few minor comments below > > >> > > > >> >> > > >> [Snip] > > >> >> /* Interfaces */ > > >> >> static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = { > > >> >> .master = &am33xx_l3_main_hwmod, > > >> >> @@ -788,6 +826,36 @@ static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = { > > >> >> .user = OCP_USER_MPU | OCP_USER_SDMA, > > >> >> }; > > >> >> > > >> >> +static struct omap_hwmod_ocp_if am43xx_l3__vpfe0 = { > > >> >> + .master = &am43xx_vpfe0_hwmod, > > >> >> + .slave = &am33xx_l3_main_hwmod, > > >> >> + .clk = "l3_gclk", > > >> >> + .flags = OCPIF_SWSUP_IDLE, > > >> > > > >> > OCPIF_SWSUP_IDLE probably isn't needed here. Could you please try without > > >> > it? > > >> > > > >> >> + .user = OCP_USER_MPU | OCP_USER_SDMA, > > >> >> +}; > > >> >> + > > >> >> +static struct omap_hwmod_ocp_if am43xx_l3__vpfe1 = { > > >> >> + .master = &am43xx_vpfe1_hwmod, > > >> >> + .slave = &am33xx_l3_main_hwmod, > > >> >> + .clk = "l3_gclk", > > >> >> + .flags = OCPIF_SWSUP_IDLE, > > >> > > > >> > Same point as the above. > > >> > > > >> Dropped and tested works! posting a v3. > > > > > > When you tested it without the OCPIF_SWSUP_IDLE, did you go trhough a complete suspend/resume cycle? > > > This flag was added early on because otherwise the susbsytem would not go idle without it... > > > > > > Can you post the console output during a suspend/resume cycle? > > > > > Ah I didn?t test the suspend/resume will do and post the console log. > > Could you also do a suspend/resume test on v2? Prabbhakar, I tested both v2 and v3 and both successfully went through a suspend/resume cycle. So I guess v3 is fine, sorry for the noise. I'll add a tested-by on V3. Benoit > > thanks > > - Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbbA1ULu (ORCPT ); Wed, 28 Jan 2015 15:11:50 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:59202 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbbA1ULP (ORCPT ); Wed, 28 Jan 2015 15:11:15 -0500 Date: Wed, 28 Jan 2015 13:30:38 -0600 From: Benoit Parrot To: Paul Walmsley CC: "Lad, Prabhakar" , Tony Lindgren , LAK , Linux OMAP Mailing List , LKML , Darren Etheridge , Felipe Balbi Subject: Re: [PATCH v2] ARM: AM43xx: hwmod: add VPFE hwmod entries Message-ID: <20150128193038.GG2570@ti.com> References: <1422217915-24231-1-git-send-email-prabhakar.csengg@gmail.com> <20150126155032.GD2570@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Walmsley wrote on Mon [2015-Jan-26 18:47:11 +0000]: > Hi Prabhakar, > > On Mon, 26 Jan 2015, Lad, Prabhakar wrote: > > > Hi Benoit, > > > > On Mon, Jan 26, 2015 at 3:50 PM, Benoit Parrot wrote: > > > Lad, Prabhakar wrote on Mon [2015-Jan-26 08:13:01 +0000]: > > >> Hi Paul, > > >> > > >> Thanks for the review. > > >> > > >> On Mon, Jan 26, 2015 at 2:15 AM, Paul Walmsley wrote: > > >> > Hi > > >> > > > >> > On Sun, 25 Jan 2015, Lad, Prabhakar wrote: > > >> > > > >> >> From: Benoit Parrot > > >> >> > > >> >> this patch adds VPFE HWMOD data for AM43xx. > > >> >> > > >> >> Signed-off-by: Benoit Parrot > > >> >> Signed-off-by: Darren Etheridge > > >> >> Signed-off-by: Felipe Balbi > > >> >> Signed-off-by: Lad, Prabhakar > > >> >> --- > > >> >> Hi Paul, > > >> >> > > >> >> You were right, the hardware team has confirmed that, the VPFE master port is > > >> >> connected to L3 and the VPFE slave port is connected to L4. The L3 port cannot > > >> >> serve as a register target because it is initiator only. > > >> > > > >> > OK makes sense to me., > > >> > > > >> >> > > >> >> I have created links referring to dss l3/l4 hwmod and tested it, lemme know > > >> >> if I have missed something. > > >> > > > >> > A few minor comments below > > >> > > > >> >> > > >> [Snip] > > >> >> /* Interfaces */ > > >> >> static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = { > > >> >> .master = &am33xx_l3_main_hwmod, > > >> >> @@ -788,6 +826,36 @@ static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = { > > >> >> .user = OCP_USER_MPU | OCP_USER_SDMA, > > >> >> }; > > >> >> > > >> >> +static struct omap_hwmod_ocp_if am43xx_l3__vpfe0 = { > > >> >> + .master = &am43xx_vpfe0_hwmod, > > >> >> + .slave = &am33xx_l3_main_hwmod, > > >> >> + .clk = "l3_gclk", > > >> >> + .flags = OCPIF_SWSUP_IDLE, > > >> > > > >> > OCPIF_SWSUP_IDLE probably isn't needed here. Could you please try without > > >> > it? > > >> > > > >> >> + .user = OCP_USER_MPU | OCP_USER_SDMA, > > >> >> +}; > > >> >> + > > >> >> +static struct omap_hwmod_ocp_if am43xx_l3__vpfe1 = { > > >> >> + .master = &am43xx_vpfe1_hwmod, > > >> >> + .slave = &am33xx_l3_main_hwmod, > > >> >> + .clk = "l3_gclk", > > >> >> + .flags = OCPIF_SWSUP_IDLE, > > >> > > > >> > Same point as the above. > > >> > > > >> Dropped and tested works! posting a v3. > > > > > > When you tested it without the OCPIF_SWSUP_IDLE, did you go trhough a complete suspend/resume cycle? > > > This flag was added early on because otherwise the susbsytem would not go idle without it... > > > > > > Can you post the console output during a suspend/resume cycle? > > > > > Ah I didn’t test the suspend/resume will do and post the console log. > > Could you also do a suspend/resume test on v2? Prabbhakar, I tested both v2 and v3 and both successfully went through a suspend/resume cycle. So I guess v3 is fine, sorry for the noise. I'll add a tested-by on V3. Benoit > > thanks > > - Paul