From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YGXpX-0007dF-P2 for mharc-grub-devel@gnu.org; Wed, 28 Jan 2015 13:59:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGXpR-0007aC-F2 for grub-devel@gnu.org; Wed, 28 Jan 2015 13:59:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGXpM-0000El-B2 for grub-devel@gnu.org; Wed, 28 Jan 2015 13:59:05 -0500 Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:56031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGXpM-0000DN-3e for grub-devel@gnu.org; Wed, 28 Jan 2015 13:59:00 -0500 Received: by mail-lb0-f170.google.com with SMTP id w7so20413996lbi.1 for ; Wed, 28 Jan 2015 10:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=2hLmH70g03AwTgf/xkSu+vgIY8tVR3cbiWHdAhhWY5o=; b=Y2S0eRa3chBrAffJVN/YWrLxEDvcg2T1NzxuTo5F3XMf+ENIZWVbl0pTInJx/dTj0k XveofxbcwYFOpM5UeOJVp+uxLTc+87+TGSg+WaMR6p+c0Nk7jXdYpO+JCOJJLnbQyy/8 UMKSSkM4rogEuoJ6x6a3OvJurxWb4wdulRPuossWajS+L+7Q8rgft+01phhd9gXv87+I Bp9VDwmGIYK4Bhz6cTLq+A16aAzBv1c3yeM+Ap3HK1VPIyA44XNsHN4s8GmEG8XInw3y d3DWTF/DRz+u3QWhshNG4wsO8Olb+FrNbi9BVzRFnTFRBeC2WdcxtE3FsAg45HYiuSBs xnNw== X-Received: by 10.112.129.195 with SMTP id ny3mr10461694lbb.10.1422471539130; Wed, 28 Jan 2015 10:58:59 -0800 (PST) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id p10sm1554005lap.10.2015.01.28.10.58.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jan 2015 10:58:58 -0800 (PST) Date: Wed, 28 Jan 2015 21:58:56 +0300 From: Andrei Borzenkov To: Leif Lindholm Subject: Re: commit 3661261f breaks arm64 Message-ID: <20150128215856.4bc94ca7@opensuse.site> In-Reply-To: <20150128183359.GG4278@bivouac.eciton.net> References: <20150128183359.GG4278@bivouac.eciton.net> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22a Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 18:59:09 -0000 =D0=92 Wed, 28 Jan 2015 18:33:59 +0000 Leif Lindholm =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > commit 3661261fe17a8fe19681073889b5b36ec1ee823d, > "Always add -msoft-float to avoid compiler generating float > arithmetics." breaks the arm64 build. >=20 > -msoft-float is not a valid command line option for aarch64 (as far as > I can see, it is technically a target-specific option which just > happens to exist for most targets - including arm). >=20 > This setting will need to be conditionalised somehow. > An option that works for arm64 is -march=3Darmv8-a+nofp+nosimd. >=20 > Would something like this be an acceptable workaround?: >=20 > diff --git a/configure.ac b/configure.ac > index a3bca06..c99e1ea 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -678,7 +678,11 @@ fi > # that floats are a good fit to run instead of what's written in the > # code. > # Given that floating point unit is disabled (if present to begin > # with) > # when GRUB is running which may result in various hard crashes. > -TARGET_CFLAGS=3D"$TARGET_CFLAGS -msoft-float" > +if ( test "x$target_cpu" =3D xarm64 ); then Why subshell? > + TARGET_CFLAGS=3D"$TARGET_CFLAGS -march=3Darmv8-a+nofp+nosimd" > +else > + TARGET_CFLAGS=3D"$TARGET_CFLAGS -msoft-float" > +fi > =20 > # By default, GCC 4.4 generates .eh_frame sections containing unwind > # information in some cases where it previously did not. GRUB doesn't > # need >=20 > / > Leif >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel