From: David Gibson <david@gibson.dropbear.id.au>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, paulus@samba.org,
agraf@suse.de, Anton Blanchard <anton@samba.org>
Subject: Re: [Qemu-devel] [PATCH] target-ppc: Use right page size with hash table lookup
Date: Thu, 29 Jan 2015 11:48:47 +1100 [thread overview]
Message-ID: <20150129004847.GK14681@voom> (raw)
In-Reply-To: <1422282118-22507-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
On Mon, Jan 26, 2015 at 07:51:58PM +0530, Aneesh Kumar K.V wrote:
> We look at two sizes specified in ISA (4K, 64K). If not found matching,
> we consider it 16MB.
>
> Without this patch we would fail to lookup address above 16MB range.
> Below 16MB happened to work before because the kernel have a liner
> mapping and we always looked up hash for 0xc000000000000000. The
> actual real address was computed by using the 16MB offset
> with the real address found with the above hash.
>
> Without Fix:
> (gdb) x/16x 0xc000000001000000
> 0xc000000001000000 <list_entries+453208>: Cannot access memory at address 0xc000000001000000
> (gdb)
>
> With Fix:
> (gdb) x/16x 0xc000000001000000
> 0xc000000001000000 <list_entries+453208>: 0x00000000 0x00000000 0x00000000 0x00000000
> 0xc000000001000010 <list_entries+453224>: 0x00000000 0x00000000 0x00000000 0x00000000
> 0xc000000001000020 <list_entries+453240>: 0x00000000 0x00000000 0x00000000 0x00000000
> 0xc000000001000030 <list_entries+453256>: 0x00000000 0x00000000 0x00000000 0x00000000
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
This doesn't fully implement the sllp page size encodings, but it's
certainly better than what's there now.
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-29 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 14:21 [Qemu-devel] [PATCH] target-ppc: Use right page size with hash table lookup Aneesh Kumar K.V
2015-01-29 0:48 ` David Gibson [this message]
2015-01-29 13:11 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129004847.GK14681@voom \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=paulus@samba.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.