From: Chao Peng <chao.p.peng@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com,
stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org,
will.auld@intel.com, keir@xen.org
Subject: Re: [PATCH v8 1/5] x86: allow reading MSR_IA32_TSC with XENPF_resource_op
Date: Thu, 29 Jan 2015 14:35:35 +0800 [thread overview]
Message-ID: <20150129063535.GA3579@pengc-linux.bj.intel.com> (raw)
In-Reply-To: <54C9117A020000780005A66C@mail.emea.novell.com>
On Wed, Jan 28, 2015 at 03:42:34PM +0000, Jan Beulich wrote:
> >>> On 28.01.15 at 09:04, <chao.p.peng@linux.intel.com> wrote:
> > + else
> > + {
> > + unsigned long irqflags;
>
> Some gcc versions can't figure out that this variable doesn't get used
> uninitialized, and hence warn about it. I fixed this while committing, at
> once changing the name to the more conventional "flags". Please be
> more careful with such conditional uses in the future.
Appreciate! I had it initialized in v5 but missed it in a latter rebase.
Chao
next prev parent reply other threads:[~2015-01-29 6:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 8:04 [PATCH v8 0/5] enable Memory Bandwidth Monitoring (MBM) for VMs Chao Peng
2015-01-28 8:04 ` [PATCH v8 1/5] x86: allow reading MSR_IA32_TSC with XENPF_resource_op Chao Peng
2015-01-28 15:42 ` Jan Beulich
2015-01-29 6:35 ` Chao Peng [this message]
2015-01-28 8:04 ` [PATCH v8 2/5] tools: add routine to get CMT L3 event mask Chao Peng
2015-01-28 13:40 ` Ian Campbell
2015-01-29 8:32 ` Chao Peng
2015-01-28 8:04 ` [PATCH v8 3/5] tools: correct coding style for psr Chao Peng
2015-01-28 8:04 ` [PATCH v8 4/5] tools: code refactoring for MBM Chao Peng
2015-01-28 8:04 ` [PATCH v8 5/5] tools, docs: add total/local memory bandwith monitoring Chao Peng
2015-01-28 14:04 ` Ian Campbell
2015-01-28 14:10 ` Ian Jackson
2015-01-28 14:12 ` Ian Campbell
2015-01-29 8:17 ` Chao Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129063535.GA3579@pengc-linux.bj.intel.com \
--to=chao.p.peng@linux.intel.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=will.auld@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.