From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Peng Subject: Re: [PATCH v8 1/5] x86: allow reading MSR_IA32_TSC with XENPF_resource_op Date: Thu, 29 Jan 2015 14:35:35 +0800 Message-ID: <20150129063535.GA3579@pengc-linux.bj.intel.com> References: <1422432286-7276-1-git-send-email-chao.p.peng@linux.intel.com> <1422432286-7276-2-git-send-email-chao.p.peng@linux.intel.com> <54C9117A020000780005A66C@mail.emea.novell.com> Reply-To: Chao Peng Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <54C9117A020000780005A66C@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Wed, Jan 28, 2015 at 03:42:34PM +0000, Jan Beulich wrote: > >>> On 28.01.15 at 09:04, wrote: > > + else > > + { > > + unsigned long irqflags; > > Some gcc versions can't figure out that this variable doesn't get used > uninitialized, and hence warn about it. I fixed this while committing, at > once changing the name to the more conventional "flags". Please be > more careful with such conditional uses in the future. Appreciate! I had it initialized in v5 but missed it in a latter rebase. Chao