Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Eric Blake (eblake@redhat.com) wrote:
> On 01/29/2015 08:54 AM, Dr. David Alan Gilbert wrote:
> >> The idea of a QMP command to trigger incoming migration looks
> >> reasonable.  We can probably use a qapi union for a nicer syntax,
> >> something like:
> >>
> >> {"execute": "migrate-incoming", "arguments": {
> >>   "type": "tcp", "port": 44 } }
> >> vs.
> >> {"execute": "migrate-incoming", "arguments": {
> >>   "type": "fd", "fd": 0 } }
> >> vs.
> >> {"execute": "migrate-incoming", "arguments": {
> >>   "type": "exec", "command": [ "cat", "/path/to/file" ] } }
> >>
> >> and so forth.
> > 
> > Compared to just taking a URI argument that Dan suggested, that's quite a
> > bit of rework to do the reworking of each transport which is pretty
> > trivial.
> 
> Yes, but getting the interface right means that adding future extensions
> will be easier, with less string parsing hacks.

I guess so, but I still have to maintain the -incoming string interface
and an HMP equivalent of whatever we come up with here.

So what would the .args_type look like in qmp-commands.hx; something like this?

  .args-type = "type:s,port:-i,host:-s,command:-s"

Dave

> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 


--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK