All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] fastboot: add "fastboot oem" command support
Date: Thu, 29 Jan 2015 17:49:28 +0100	[thread overview]
Message-ID: <201501291749.29028.marex@denx.de> (raw)
In-Reply-To: <20150129093027.1aba1a15@amdc2363>

On Thursday, January 29, 2015 at 09:30:27 AM, Lukasz Majewski wrote:
> Hi Rob,

Hi all!

> > From: Michael Scott <michael.scott@linaro.org>
> > 
> > Add code stub to handle "fastboot oem __" command. As unlock is a
> > common fastboot command, distinguish that it is not implemented.
> > 
> > Signed-off-by: Michael Scott <michael.scott@linaro.org>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > 
> >  drivers/usb/gadget/f_fastboot.c | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/drivers/usb/gadget/f_fastboot.c
> > b/drivers/usb/gadget/f_fastboot.c index 310175a..e2fda86 100644
> > --- a/drivers/usb/gadget/f_fastboot.c
> > +++ b/drivers/usb/gadget/f_fastboot.c
> > @@ -513,6 +513,17 @@ static void cb_flash(struct usb_ep *ep, struct
> > usb_request *req) }
> > 
> >  #endif
> > 
> > +static void cb_oem(struct usb_ep *ep, struct usb_request *req)
> > +{
> > +	char *cmd = req->buf;
> > +	if (strncmp("unlock", cmd + 4, 8) == 0) {
> > +		fastboot_tx_write_str("FAILnot implemented");
> > +	}
> > +	else {
> > +		fastboot_tx_write_str("FAILunknown oem command");
> > +	}
> 
> Just a minor comment - those braces could be removed.
> 
> BTW: Marek shall I take those patches to dfu tree or would you take
> them to -usb tree ?

Take them through DFU please, thank you!

Best regards,
Marek Vasut

  reply	other threads:[~2015-01-29 16:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 21:48 [U-Boot] [PATCH 0/2] Fastboot OEM commands Rob Herring
2015-01-26 21:49 ` [U-Boot] [PATCH 1/2] fastboot: add "fastboot oem" command support Rob Herring
2015-01-29  8:30   ` Lukasz Majewski
2015-01-29 16:49     ` Marek Vasut [this message]
2015-01-30 14:20     ` Rob Herring
2015-01-30 14:29       ` Lukasz Majewski
2015-01-29 23:27   ` Steve Rae
2015-01-30 15:02   ` Lukasz Majewski
2015-01-26 21:49 ` [U-Boot] [PATCH 2/2] fastboot: add support for "oem format" command Rob Herring
2015-01-29  8:31   ` Lukasz Majewski
2015-01-29 23:27   ` Steve Rae
2015-01-30 15:03   ` Lukasz Majewski
2015-02-11 19:44   ` Steve Rae
2015-02-12  1:46     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201501291749.29028.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.