All of lore.kernel.org
 help / color / mirror / Atom feed
From: ulrik.debie-os@e2big.org
To: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	dmitry.torokhov@gmail.com
Subject: Re: input: elantech.c: adding comment lines for Fujitsu notebooks
Date: Thu, 29 Jan 2015 23:35:22 +0100	[thread overview]
Message-ID: <20150129223521.GA7563@lantern> (raw)
In-Reply-To: <54CA259B.8050602@ts.fujitsu.com>


Thanks Rainer,

According to the top bit of the first byte of the caps, the Fujitsu LIFEBOOK
E544 reports a trackpoint, the Fujitsu LIFEBOOK E554 does not.

This would mean that if you equip the E544 with a trackpoint, the trackpoint 
will work with the next kernel release, but the trackpoint of the E554, when 
the laptop is equipped with a trackpoint, will not.

I wonder if you can make the trackpoint work on the E554 when equipped
with trackpoint when you force the if test 
       /* The MSB indicates the presence of the trackpoint */
        if ((etd->capabilities[0] & 0x80) == 0x80) {
to always succeed ?

Thanks,
Kind regards,
Ulrik

On Thu, Jan 29, 2015 at 01:20:43PM +0100, Rainer Koenig wrote:
> Ulrik asked me to add some comment lines for the patch I submitted on January 27.
> 
> Signed-off-by: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
> ---
> 
> diff -uNr old/drivers/input/mouse/elantech.c new/drivers/input/mouse/elantech.c
> --- old/drivers/input/mouse/elantech.c	2015-01-29 13:10:04.628549594 +0100
> +++ new/drivers/input/mouse/elantech.c	2015-01-29 13:12:38.574624972 +0100
> @@ -1097,6 +1097,8 @@
>   * Asus UX31               0x361f00        20, 15, 0e      clickpad
>   * Asus UX32VD             0x361f02        00, 15, 0e      clickpad
>   * Avatar AVIU-145A2       0x361f00        ?               clickpad
> + * Fujitsu LIFEBOOK E544   0x470f00        d0, 12, 09      2 hw buttons
> + * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
>   * Fujitsu H730            0x570f00        c0, 14, 0c      3 hw buttons (**)
>   * Gigabyte U2442          0x450f01        58, 17, 0c      2 hw buttons
>   * Lenovo L430             0x350f02        b9, 15, 0c      2 hw buttons (*)
> 
> -- 
> Dipl.-Inf. (FH) Rainer Koenig
> Project Manager Linux Clients
> Dept. PDG WPS R&D SW OSE
> 
> Fujitsu Technology Solutions
> Bürgermeister-Ullrich-Str. 100
> 86199 Augsburg
> Germany
> 
> Telephone: +49-821-804-3321
> Telefax:   +49-821-804-2131
> Mail:      mailto:Rainer.Koenig@ts.fujitsu.com
> 
> Internet         ts.fujtsu.com
> Company Details  ts.fujitsu.com/imprint.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-01-29 23:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 12:20 input: elantech.c: adding comment lines for Fujitsu notebooks Rainer Koenig
2015-01-29 22:35 ` ulrik.debie-os [this message]
2015-01-30  7:13   ` Rainer Koenig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150129223521.GA7563@lantern \
    --to=ulrik.debie-os@e2big.org \
    --cc=Rainer.Koenig@ts.fujitsu.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.