From: Thierry Reding <thierry.reding@gmail.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: marcheu@chromium.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/tegra: Add tegra_gem_mmap2 to fix 64-bit offsets
Date: Fri, 30 Jan 2015 10:49:35 +0100 [thread overview]
Message-ID: <20150130094935.GB16744@ulmo> (raw)
In-Reply-To: <1422559121-24477-1-git-send-email-seanpaul@chromium.org>
[-- Attachment #1.1: Type: text/plain, Size: 1044 bytes --]
On Thu, Jan 29, 2015 at 02:18:41PM -0500, Sean Paul wrote:
> On 64-bit targets, tegra_gem_mmap doesn't return the
> offset to userspace. As such, subsequent calls to mmap(2)
> fail. Add a new tegra_gem_mmap2 ioctl to fix this.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> drivers/gpu/drm/tegra/drm.c | 21 +++++++++++++++++++++
> include/uapi/drm/tegra_drm.h | 9 +++++++++
> 2 files changed, 30 insertions(+)
To be honest, I'd rather just fix the existing IOCTL to do the right
thing on 64-bit. All IOCTLs are still protected by the DRM_TEGRA_STAGING
Kconfig symbol which depends on STAGING. We originally did that
precisely so we'd have some leeway in fixing things up. And we've done
precisely that in the past.
The only user of this IOCTL is libdrm and I don't think that has any
users aside from a few projects that are still under heavy development
(like grate or the xf86-video-opentegra driver).
Cc'ing Erik, who's probably the only one that's ever worked with this,
besides me.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-01-30 9:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 18:46 [PATCH] drm/tegra: Add tegra_gem_mmap2 to fix 64-bit offsets Sean Paul
2015-01-29 18:55 ` Rob Clark
2015-01-29 19:18 ` [PATCH v2] " Sean Paul
2015-01-29 20:11 ` Rob Clark
2015-01-30 9:49 ` Thierry Reding [this message]
2015-01-30 10:15 ` Erik Faye-Lund
2015-01-30 10:21 ` Thierry Reding
2015-01-30 11:41 ` Emil Velikov
2015-01-30 18:57 ` [PATCH v3] drm/tegra: Use 64-bit offset for tegra_gem_mmap Sean Paul
2015-02-06 12:18 ` Thierry Reding
2015-06-28 20:54 ` Dmitry
2015-06-29 8:46 ` Thierry Reding
2015-06-29 4:16 ` Dave Airlie
2015-06-29 8:50 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130094935.GB16744@ulmo \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=marcheu@chromium.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.