From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH8E4-0001uP-Ao for qemu-devel@nongnu.org; Fri, 30 Jan 2015 04:51:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YH8E0-0007KO-7O for qemu-devel@nongnu.org; Fri, 30 Jan 2015 04:50:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH8Dz-0007KK-RT for qemu-devel@nongnu.org; Fri, 30 Jan 2015 04:50:52 -0500 Date: Fri, 30 Jan 2015 09:50:47 +0000 From: "Daniel P. Berrange" Message-ID: <20150130095047.GA27572@redhat.com> References: <1422543997-22808-2-git-send-email-dgilbert@redhat.com> <20150129151527.GE1102@redhat.com> <54CA500E.8030608@redhat.com> <20150129155425.GE2391@work-vm> <54CA594E.5030605@redhat.com> <20150129162815.GG2391@work-vm> <54CA71CD.3090304@redhat.com> <20150129202154.GH2391@work-vm> <54CA9C8C.7030906@redhat.com> <20150130093849.GB2370@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150130093849.GB2370@work-vm> Subject: Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: amit.shah@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, quintela@redhat.com On Fri, Jan 30, 2015 at 09:38:50AM +0000, Dr. David Alan Gilbert wrote: > * Eric Blake (eblake@redhat.com) wrote: > > On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote: > > > * Eric Blake (eblake@redhat.com) wrote: > > >> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: > > >>> > > >>> So what would the .args_type look like in qmp-commands.hx; something like this? > > >>> > > >>> .args-type = "type:s,port:-i,host:-s,command:-s" > > >> > > >> No, it would be more like the blockdev-add interface, where one command > > >> accepts a dictionary object containing a union of valid values, where > > >> the set of valid values is determined by the discriminator field. > > >> .args_type = "options:q". > > > > > > What causes the parser to generate a 'BlockdevOptions' as opposed to any > > > standard options type for the parameter of qmp_blockdev_add? > > > > Kevin Wolf has the most experience here, as he was the one that figured > > out how to correlate command line and QMP as part of adding blockdev-add. > > OK, this is getting more complicated than I'd expected; how about a simpler > suggestion. > > The current suggestion is: > Modify -incoming to take 'pause' as an argument > Add migrate-incoming command that takes parsed URI FWIW, the existing source side 'migrate' command already expects URI string, so personally I'm fine with the dest side 'migrate-incoming' also taking a URI string. I don't think we need to explode the URI into its pieces. URI is a well defined data format we should feel free to use when appropriate. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|