Re: [nf-next PATCH v2] netfilter: nft_compat: add ebtables support

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Thu, Jan 29, 2015 at 07:34:42PM +0100, Arturo Borrero Gonzalez wrote:
> This patch extends nft_compat to support ebtables extensions.
> 
> ebtables verdict codes are translated to the ones used by the nf_tables engine,
> so we can properly use ebtables target extensions from nft_compat.

Applied with minor nitpick, thanks Arturo.

> diff --git a/net/netfilter/nft_compat.c b/net/netfilter/nft_compat.c
> index 265e190..73ec6ef 100644
> --- a/net/netfilter/nft_compat.c
> +++ b/net/netfilter/nft_compat.c
> @@ -66,7 +68,7 @@ static void nft_target_eval(const struct nft_expr *expr,
>  	if (pkt->xt.hotdrop)
>  		ret = NF_DROP;
>  
> -	switch(ret) {
> +	switch (ret) {
>  	case XT_CONTINUE:
>  		data[NFT_REG_VERDICT].verdict = NFT_CONTINUE;
>  		break;
> @@ -74,6 +76,44 @@ static void nft_target_eval(const struct nft_expr *expr,
>  		data[NFT_REG_VERDICT].verdict = ret;
>  		break;
>  	}
> +
> +	return;

Removed this return, we don't need it.

> +}