Re: [PATCH] staging: rtl8188eu: core: rtw_mlme: Removed variables that is never used

[Dan Carpenter <dan.carpenter@oracle.com>]

On Sat, Jan 31, 2015 at 03:44:33PM +0100, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---

> @@ -2042,7 +2039,7 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len)
>  		phtpriv->rx_ampdu_maxlen = max_ampdu_sz;
>  	}
>  	len = 0;
> -	p = rtw_get_ie(pie+sizeof(struct ndis_802_11_fixed_ie), _HT_ADD_INFO_IE_, &len, ie_len-sizeof(struct ndis_802_11_fixed_ie));
> +	rtw_get_ie(pie+sizeof(struct ndis_802_11_fixed_ie), _HT_ADD_INFO_IE_, &len, ie_len-sizeof(struct ndis_802_11_fixed_ie));

Nope.

And delete the "len = 0" line as well.

Rickard, these are too many patches and you didn't think about them
carefully enough.  I'm not reviewing the rest.

regards,
dan carpenter