From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbbBAEg1 (ORCPT ); Sat, 31 Jan 2015 23:36:27 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57894 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751933AbbBAEg0 (ORCPT ); Sat, 31 Jan 2015 23:36:26 -0500 Date: Sat, 31 Jan 2015 20:19:48 -0800 From: Greg Kroah-Hartman To: Rickard Strandqvist Cc: Arnaud Patard , devel@driverdev.osuosl.org, Aaro Koskinen , linux-kernel@vger.kernel.org, Vitor Braga , Thomas Gummerer Subject: Re: [PATCH] staging: xgifb: vb_init: Removed variables that is never used Message-ID: <20150201041948.GA25151@kroah.com> References: <1422717648-7274-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422717648-7274-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 31, 2015 at 04:20:48PM +0100, Rickard Strandqvist wrote: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/xgifb/vb_init.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c > index 2b233af..6384077 100644 > --- a/drivers/staging/xgifb/vb_init.c > +++ b/drivers/staging/xgifb/vb_init.c > @@ -1187,7 +1187,7 @@ unsigned char XGIInitNew(struct pci_dev *pdev) > struct xgi_hw_device_info *HwDeviceExtension = &xgifb_info->hw_info; > struct vb_device_info VBINF; > struct vb_device_info *pVBInfo = &VBINF; > - unsigned char i, temp = 0, temp1; > + unsigned char i, temp = 0; > > pVBInfo->FBAddr = HwDeviceExtension->pjVideoMemoryAddress; > > @@ -1286,8 +1286,6 @@ unsigned char XGIInitNew(struct pci_dev *pdev) > /* disable VideoCapture */ > xgifb_reg_and_or(pVBInfo->Part0Port, 0x3F, 0xEF, 0x00); > xgifb_reg_set(pVBInfo->Part1Port, 0x00, 0x00); > - /* chk if BCLK>=100MHz */ > - temp1 = xgifb_reg_get(pVBInfo->P3d4, 0x7B); With hardware, you can't just remove all 'read' calls and expect things to work because a static code checker things something is not right. I'm going to drop _all_ of the patches you sent me in the past few days as I really think they all are wrong. Please be more careful and work on fixing real problems, not just ones that random tools think might be wrong. Weeding out false-positives should not be my job, that's not scalable at all. sorry, greg k-h