diff for duplicates of <20150201205425.GC29298@mwanda> diff --git a/a/1.txt b/N1/1.txt index 85199f3..f1cc688 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,5 +1,5 @@ The bug here is that we use "Reject" as the index into the cau_t[] array -in the else path. Since the cau_t[] has 9 elements if Reject = 9 then +in the else path. Since the cau_t[] has 9 elements if Reject == 9 then we are reading beyond the end of the array. My understanding of the code is that it's saying that if Reject is 1 or @@ -18,8 +18,8 @@ index 0b38060..d7c2866 100644 add_ai(plci, &parms[5]); sig_req(plci, REJECT, 0); } -- else if (Reject = 1 || Reject > 9) -+ else if (Reject = 1 || Reject >= 9) +- else if (Reject == 1 || Reject > 9) ++ else if (Reject == 1 || Reject >= 9) { add_ai(plci, &parms[5]); sig_req(plci, HANGUP, 0); diff --git a/a/content_digest b/N1/content_digest index 209ca6c..e1a0931 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[patch] isdn: off by one in connect_res()\0" - "Date\0Sun, 01 Feb 2015 20:54:25 +0000\0" + "Date\0Sun, 1 Feb 2015 23:54:25 +0300\0" "To\0Armin Schindler <mac@melware.de>\0" "Cc\0Karsten Keil <isdn@linux-pingi.de>" netdev@vger.kernel.org @@ -8,7 +8,7 @@ "\00:1\0" "b\0" "The bug here is that we use \"Reject\" as the index into the cau_t[] array\n" - "in the else path. Since the cau_t[] has 9 elements if Reject = 9 then\n" + "in the else path. Since the cau_t[] has 9 elements if Reject == 9 then\n" "we are reading beyond the end of the array.\n" "\n" "My understanding of the code is that it's saying that if Reject is 1 or\n" @@ -27,10 +27,10 @@ " \t\t\t\t\tadd_ai(plci, &parms[5]);\n" " \t\t\t\t\tsig_req(plci, REJECT, 0);\n" " \t\t\t\t}\n" - "-\t\t\t\telse if (Reject = 1 || Reject > 9)\n" - "+\t\t\t\telse if (Reject = 1 || Reject >= 9)\n" + "-\t\t\t\telse if (Reject == 1 || Reject > 9)\n" + "+\t\t\t\telse if (Reject == 1 || Reject >= 9)\n" " \t\t\t\t{\n" " \t\t\t\t\tadd_ai(plci, &parms[5]);\n" " \t\t\t\t\tsig_req(plci, HANGUP, 0);" -0b244aa11d1dd9d3ae9e5a378751e398121d8aa26307f30a287a953cef380ac2 +9ab118224c0a8b3b8e3916156de844ddaf3965c2c920be4bfb5f42aa3fded236
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.