All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Brian Foster <bfoster@redhat.com>, Christoph Hellwig <hch@lst.de>,
	xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: don't allocate an ioend for direct I/O completions
Date: Mon, 2 Feb 2015 08:27:16 +0100	[thread overview]
Message-ID: <20150202072716.GA9378@lst.de> (raw)
In-Reply-To: <20150201230403.GD4251@dastard>

On Mon, Feb 02, 2015 at 10:04:03AM +1100, Dave Chinner wrote:
> > A nit, but I guess you could kill the braces here now too.
> 
> Given it's a multi-line return statement, the braces are fine. FWIW,
> when we have a if () { return ...} else { return ... } we normally
> kill the else. i.e:
> 
> 	if (rw & WRITE) {
> 		return foo(
> 			bar,
> 			baz);
> 	}
> 	return .....;
> 
> So I modified it like this.

For an if/else that is 100% symmetric like read vs write I prefer
to keep the else, otherwise I agree.  But in the end it's a very
minor point, so it doesn't really matter.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2015-02-02  7:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 22:54 [PATCH] xfs: don't allocate an ioend for direct I/O completions Christoph Hellwig
2015-01-30 14:42 ` Brian Foster
2015-02-01 23:04   ` Dave Chinner
2015-02-02  7:27     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150202072716.GA9378@lst.de \
    --to=hch@lst.de \
    --cc=bfoster@redhat.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.