Re: [RFC 5/5] watchdog: sh_mobile: add driver

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]


> > +	sh_wdt_start(&priv->wdev);
> > +	sh_wdt_write(priv, 0xfff0, RWTCNT);
> 
> Is there a reason to set the counter to 0xfff0 instead of 0xffff ?

Giving serial console some time to push out FIFOs. But yeah, it is an
arbitrary value.

> > +	priv->restart_handler.notifier_call = sh_mobile_wdt_restart_handler;
> > +	priv->restart_handler.priority = 192;
> 
> Just for my information, how did you choose 192 for the priority ?

Assuming DA9063 is 128, then I wanted to give this priority since it
doesn't need I2C access which might be stalled.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]