From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44695)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YIMEK-0004Sb-Hh
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 14:00:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YIMEH-0001Y3-B5
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 14:00:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56214)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YIMEH-0001Xo-40
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 14:00:13 -0500
Date: Mon, 2 Feb 2015 20:00:04 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150202190004.GD19586@noname.redhat.com>
References: <1422284444-12529-1-git-send-email-mreitz@redhat.com>
	<1422284444-12529-7-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1422284444-12529-7-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 06/14] qemu-img: Use blk_new_open() in
	img_rebase()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>

Am 26.01.2015 um 16:00 hat Max Reitz geschrieben:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  qemu-img.c | 57 ++++++++++++++++++++++++---------------------------------
>  1 file changed, 24 insertions(+), 33 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index be1953d..0b23c87 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -2430,7 +2430,6 @@ static int img_rebase(int argc, char **argv)
>  {
>      BlockBackend *blk = NULL, *blk_old_backing = NULL, *blk_new_backing = NULL;
>      BlockDriverState *bs = NULL, *bs_old_backing = NULL, *bs_new_backing = NULL;
> -    BlockDriver *old_backing_drv, *new_backing_drv;
>      char *filename;
>      const char *fmt, *cache, *src_cache, *out_basefmt, *out_baseimg;
>      int c, flags, src_flags, ret;
> @@ -2524,54 +2523,46 @@ static int img_rebase(int argc, char **argv)
>      }
>      bs = blk_bs(blk);
>  
> -    /* Find the right drivers for the backing files */
> -    old_backing_drv = NULL;
> -    new_backing_drv = NULL;
> -
> -    if (!unsafe && bs->backing_format[0] != '\0') {
> -        old_backing_drv = bdrv_find_format(bs->backing_format);
> -        if (old_backing_drv == NULL) {
> -            error_report("Invalid format name: '%s'", bs->backing_format);
> -            ret = -1;
> -            goto out;
> -        }
> -    }
> -
> -    if (out_basefmt != NULL) {
> -        new_backing_drv = bdrv_find_format(out_basefmt);
> -        if (new_backing_drv == NULL) {
> -            error_report("Invalid format name: '%s'", out_basefmt);
> -            ret = -1;
> -            goto out;
> -        }
> -    }

You're removing the validity check of the new backing file format:

[master] $ ./qemu-img rebase -u -b /tmp/backing.qcow2 -F foobar /tmp/test.qcow2 
qemu-img: Invalid format name: 'foobar'
[master] $

[growable-v3] $ ./qemu-img rebase -u -b /tmp/backing.qcow2 -F foobar /tmp/test.qcow2
[growable-v3] $

Kevin