From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 2/3] drm/panel: add s6e63j0x03 LCD panel driver Date: Tue, 3 Feb 2015 15:00:18 +0100 Message-ID: <20150203140016.GI15068@ulmo.nvidia.com> References: <1421653953-8187-1-git-send-email-human.hwang@samsung.com> <1421653953-8187-2-git-send-email-human.hwang@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0117803495==" Return-path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 74F2E6E067 for ; Tue, 3 Feb 2015 06:00:23 -0800 (PST) Received: by mail-pa0-f49.google.com with SMTP id fa1so96629905pad.8 for ; Tue, 03 Feb 2015 06:00:23 -0800 (PST) In-Reply-To: <1421653953-8187-2-git-send-email-human.hwang@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hyungwon Hwang Cc: treding@nvidia.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0117803495== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zgY/UHCnsaNnNXRx" Content-Disposition: inline --zgY/UHCnsaNnNXRx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 19, 2015 at 04:52:32PM +0900, Hyungwon Hwang wrote: > From: Inki Dae >=20 > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver > which uses mipi_dsi bus to communicate with panel. The panel has > 320=C3=97320 resolution in 1.63-inch physical panel. This panel is used in > Samsung Galaxy Gear 2. >=20 > Signed-off-by: Inki Dae > Signed-off-by: Hyungwon Hwang > Acked-by: Kyungmin Park > --- > Changes for v2: > - Change the gamma table to 2-dimensional array > - Change the way to make index for brightness > - Make command functions to an array so that it can be called simply > - Change command id for reading device ID > - Change the way to handle the error condition > - Remove power variable, and use the same name variable in bl_dev > - Add the state FB_BLANK_NORMAL to represent the state which the panel > is working but blanked > - Miscellaneous changes to increase the readability and follow the > coding-style standard > Changes for v3: > - Add DT binding documentation > - Add the code getting DT properties of 'panel-width-mm' and 'panel-heigh= t-mm' > - Remove the code getting unnecessary DT properties flip-* > .../bindings/panel/samsung,s6e63j0x03.txt | 55 +++ > drivers/gpu/drm/panel/Kconfig | 6 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-s6e63j0x03.c | 546 +++++++++++++++= ++++++ > 4 files changed, 608 insertions(+) > create mode 100644 Documentation/devicetree/bindings/panel/samsung,s6e63= j0x03.txt > create mode 100644 drivers/gpu/drm/panel/panel-s6e63j0x03.c I have pretty much the same comments as for the SA6E3HA2 panel driver that I reviewed earlier. Thierry --zgY/UHCnsaNnNXRx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU0NRwAAoJEN0jrNd/PrOhUOMP/2e0kESUhgeLB/6ZwY2SZEva XeKNBrdTVLaSpMJyQ1hAgECp32yjpMSpxzoddpolWtoAH6QdVOcJotpNj5s4UYJq qLEmiSNqbKICNNGwRZWWwSQZQZhtnnck+WAagrjEwJBzlVLXo5PfCQo+YsDhMgxD 6AtLbdYAH03thK/85d+v3FEAxZaSORNzjJ6/LCjsETd01YAIsSMkXuyvzCH8h3+D Ef3fk4KhpZ50g8sseUDgfcn47NWjupsA0cm1AR1CBD7xK7QgY87av2tAaVWHHJ0M YuhWch5XtOdB3a+lIiLZ4lAHuqohW81M3C7n6kwkEyKoj4nrGAOSfvQ+z+u2nvID KbDPIpr6J+HEhp0frkmMOh/YBMHaOPk6Jyw0SNWCAodqTrbsLlQKlRXodSdMSqTJ oZ2OSgnkVS1uvLm+rMXFZDT6p5GwKQHTaOrCaEdxeZcfZFMhKdZaAO2AdCQZhNMd rFh9ylHgsKW3wI1P3Wmy5N3SvF4KU0Hya1uujJa3mSBlhLIaG7oMu27/jaKLy0CS +Ty3ij6iC0dQZxyqUhYsZOUC4aFYau3gAUjdRXe3XmvNb7/csA0YjOwHeURiQW9O aAOc+HeZitttBO0bH9a1bgYICbjGQNvi+Ey7XjR93fsDJ4axl4JrLRrFf/BWlFKi Rh8BYKwlzScWCTELVYTS =yEAn -----END PGP SIGNATURE----- --zgY/UHCnsaNnNXRx-- --===============0117803495== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0117803495==--