From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966439AbbBCTfm (ORCPT ); Tue, 3 Feb 2015 14:35:42 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:47887 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756091AbbBCTfk (ORCPT ); Tue, 3 Feb 2015 14:35:40 -0500 Date: Tue, 3 Feb 2015 13:35:25 -0600 From: Felipe Balbi To: Pali =?iso-8859-1?Q?Roh=E1r?= CC: , Linux USB Mailing List , Pavel Machek , Aaro Koskinen , Sebastian Reichel , Subject: Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls Message-ID: <20150203193525.GC6508@saruman.tx.rr.com> Reply-To: References: <1422918921-5472-1-git-send-email-balbi@ti.com> <201502031717.28789@pali> <20150203191859.GA6508@saruman.tx.rr.com> <201502032027.52712@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VMt1DrMGOVs3KQwf" Content-Disposition: inline In-Reply-To: <201502032027.52712@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --VMt1DrMGOVs3KQwf Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Roh=E1r wrote: > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Roh=E1r wrote: > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > > Hi, > > > >=20 > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Roh=E1r wrote: > > > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > > > > f_phonet's ->set_alt() method will call > > > > > > usb_ep_disable() potentially on an endpoint which is > > > > > > already disabled. That's something the > > > > > > gadget/function driver must guarantee that it's > > > > > > always balanced. > > > > > >=20 > > > > > > In order to balance the calls, just make sure the > > > > > > endpoint was enabled before by means of checking the > > > > > > validity of driver_data. > > > > > >=20 > > > > > > Reported-by: Pali Roh=E1r > > > > > > Signed-off-by: Felipe Balbi > > > > > > --- > > > > >=20 > > > > > Your patches cause that kernel does not print any error > > > > > message to n900 screen anymore and reboot device in 10 > > > > > seconds. I did not loaded any external modules. > > > >=20 > > > > > In qemu I see this crash in early boot: > > > > alright, so n900's working fine. I'll wait until you debug > > > > qemu a little more, thank you > > >=20 > > > NO! It does not working, see ^^^^. It break n900 totally! > >=20 > > settle down a bit more. I don't have the HW you have and > > things are working fine on boards I _do_ have, there's not > > much more I can do to help without you doing your homework. > > Debug a bit more and bring more information as to what's > > going on, until then you're on your own. >=20 > And what more do you need? It crash on my n900 and also in qemu.=20 > I sent you kernel crash dump from qemu which introduced *your*=20 > patches. Before applying your patches there was no crash in early=20 > boot stage. >=20 > In current state I review all 3 patches as: >=20 > Rejected-by: Pali Roh=E1r > [It breaks booting Nokia N900 device] next step, figure why it's broken. Working just fine here on AM335x which has the same musb IP. --=20 balbi --VMt1DrMGOVs3KQwf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU0SL9AAoJEIaOsuA1yqREoI4QAJc2iN8MlXw2hMYNZGLi7qUi qI1eKXMlqVYQNEZB+kCSnmi9cc3mWhJcKOlxQ0xXuiiO3nyeYB0N7tCacrMq+KOw 9KUtMWnHlwetZ1B0aRkRQ3umzDXmx1Cg81wa/Q/v6SPKMrwUQwd508YnHExYo74V D5xpG6CKHEEwJvh5pLWJI58ofqVt9UGmN03KMHzz5mnD1TJBPhG6/98magMPwDXQ UAOGBS7HtyZ8wShPd5rR4YJgrG2mpC5zgFHJtE02DkHmUEeE4hB8OZZm8w2n4WQq YPS3ACfMtWODHCyZodAwJ/8PBehxL94HauJFobhX0J4cmMsd9Vl0MPpVtv3+kJ5X OIXcXa1EU6tQiH3vyyQJ8U56t9YuQNUBDU2HV73FLd50eaKVF498wT7Hnyjof1s9 +G3VZrOi4EGjhTUTersX53pISLgqsA9PjBb0d4z9lOgZl/jyffT0qDj5pT4LP3r5 jw/DtCxkS46yUZ3oqS+dJup7QIH9l+ojqhKBziE8KGxe8R1xcDDCBM1v3/Hg9QkW pf2Wq3ykxb9j0v2KLMsYeNipcQtB1SdNTtn3NHY5wQOaurln+xx3FBb4nMAoixUg MHangMzCjh46cYCrn7+Ws/XvD/TwIb4VGqINv5yyzjRRnVVu38A5d45UaQWvAdaI 7Rqsf/MgvTXfEMHhvSxv =dyPg -----END PGP SIGNATURE----- --VMt1DrMGOVs3KQwf--