From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [Patch 3.14 stable 00/16] vfs: fix dentry shrink list corruption Date: Tue, 3 Feb 2015 15:11:31 -0800 Message-ID: <20150203231131.GA10307@kroah.com> References: <1415302640-5876-1-git-send-email-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: stable@vger.kernel.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Cong Wang Return-path: Content-Disposition: inline In-Reply-To: <1415302640-5876-1-git-send-email-xiyou.wangcong@gmail.com> Sender: stable-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Nov 06, 2014 at 11:37:04AM -0800, Cong Wang wrote: > On at least 3 different machines, we have seen dentry shrink list corruption > with 3.14 stable kernel (see the end of this email), which I think is > fixed by a set of patches from Al. > > This bug is probably introduced by the following commit in 3.12: > > commit dd1f6b2e43a53ee58eb87d5e623cf44e277d005d > Author: Dave Chinner > Date: Wed Aug 28 10:17:55 2013 +1000 > > dcache: remove dentries from LRU before putting on dispose list > > since previously we held the per sb lock. It is hard to reproduce this bug, > because it is a race condition which happens when we update two contiguous > dentries on a shrink list. Matt ran some ltp stress tests and doesn't see > any problem with the patched kernel. And, 3.13 needs them too, but we have > no time or resource to backport or test them on 3.13. > > The first 7 patches are the original patchset from Al, the rest of patches > are either needed for context or are folllow-up fixes, especially the > last 2 patches. Of course all of them are merged in upstream, see each patch > for details. Note, I don't get any conflict when backporting them to 3.14. > > Signed-off-by: Cong Wang > Tested-by: Matthew Mullins I'm not ignoring these, just waiting for the other major 3.14-stable patches that I've merged over the past few releases to settle down and ensure they work properly. It will probably be a few more weeks before I can get to these, don't worry, they aren't lost. thanks, greg k-h