From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
Cc: Tom Zanussi <tom.zanussi@linux.intel.com>,
Otavio Salvador <otavio@ossystems.com.br>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] wic: use kB for the partitions size
Date: Wed, 4 Feb 2015 11:53:06 +0100 [thread overview]
Message-ID: <20150204105306.GA4060@piout.net> (raw)
In-Reply-To: <20150204102923.GA3901@localhost.localdomain>
On 04/02/2015 at 11:29:23 +0100, Maciej Borzecki wrote :
> > + mapping = {"opt": opt, "value": value}
> > + if (not value[0:len(value)-1].isdigit()):
>
> You might want to replace value[0:len(value)-1] with value[:-1] here and
> in int(...) below.
>
Ah sure, I was looking for a better way to do that, thanks!
> Other than that, the patch looks ok for me. I've built a couple of
> images with different sizes (with and without suffix), all worked fine.
>
> Tested-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-02-04 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 23:40 [PATCH] wic: use kB for the partitions size Alexandre Belloni
2015-02-04 10:29 ` Maciej Borzecki
2015-02-04 10:53 ` Alexandre Belloni [this message]
2015-02-04 18:32 ` Tom Zanussi
2015-02-04 18:42 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204105306.GA4060@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=maciej.borzecki@open-rnd.pl \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.