From: Nicholas Mc Guire <der.herr@hofr.at>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Abel Moyo <abelmoyo.ab@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: rtl8188eu: core: switch with redundant cases
Date: Wed, 4 Feb 2015 14:16:33 +0100 [thread overview]
Message-ID: <20150204131633.GA23913@opentech.at> (raw)
In-Reply-To: <20150204114324.GB5336@mwanda>
On Wed, 04 Feb 2015, Dan Carpenter wrote:
> Btw, what tool are you using to find these?
>
working on a set of coccinell scripts - they are not yet
really clean - but this one is simply:
virtual context
virtual patch
virtual org
virtual report
@assign@
position p;
statement S1;
@@
<+...
* if@p (...) S1 else S1
...+>
@script:python@
p << assign.p;
@@
print "%s:%s WARNING: condition with no effect" % (p[0].file,p[0].line)
I guess this is not wildly impressive - but it seems to be effective
in finding a lot of broken code. The rate of false postivs has been
supprisingly low (very few case of intentional if==else like in
./fs/kernfs/file.c:661 - which is nicely documented)
thx!
hofrat
next prev parent reply other threads:[~2015-02-04 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 11:04 [PATCH] staging: rtl8188eu: core: switch with redundant cases Nicholas Mc Guire
2015-02-04 11:42 ` Dan Carpenter
2015-02-04 11:43 ` Dan Carpenter
2015-02-04 13:16 ` Nicholas Mc Guire [this message]
2015-02-04 12:07 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204131633.GA23913@opentech.at \
--to=der.herr@hofr.at \
--cc=Larry.Finger@lwfinger.net \
--cc=abelmoyo.ab@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.