From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44349)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YJ0Ow-0002Vc-DW
	for qemu-devel@nongnu.org; Wed, 04 Feb 2015 08:53:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YJ0Oq-00065r-5o
	for qemu-devel@nongnu.org; Wed, 04 Feb 2015 08:53:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60728)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YJ0Op-00065f-W0
	for qemu-devel@nongnu.org; Wed, 04 Feb 2015 08:53:48 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t14DrlPB013876
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 4 Feb 2015 08:53:47 -0500
Date: Wed, 4 Feb 2015 14:53:45 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150204135345.GD5641@noname.redhat.com>
References: <1418647857-3589-1-git-send-email-mreitz@redhat.com>
	<1418647857-3589-12-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1418647857-3589-12-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 11/26] qcow2: More helpers for refcount
	modification
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 15.12.2014 um 13:50 hat Max Reitz geschrieben:
> Add helper functions for getting and setting refcounts in a refcount
> array for any possible refcount order, and choose the correct one during
> refcount initialization.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Hm... Wouldn't it be better to have a single generic implementation that
is based on uint64_t* and calculates the right shifts and bitmasks on
the fly?

Kevin