All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] regulator: Fix build breakage on !REGULATOR
Date: Wed, 4 Feb 2015 16:22:59 +0100	[thread overview]
Message-ID: <20150204152259.GN3702@8bytes.org> (raw)
In-Reply-To: <1423047011.3987.2.camel@AMDC1943>

On Wed, Feb 04, 2015 at 11:50:11AM +0100, Krzysztof Kozlowski wrote:
> >  #ifdef CONFIG_REGULATOR
> >  void regulator_has_full_constraints(void);
> > +int regulator_suspend_prepare(suspend_state_t state);
> > +int regulator_suspend_finish(void);
> >  #else
> >  static inline void regulator_has_full_constraints(void)
> >  {
> >  }
> > +static inline int regulator_suspend_prepare(suspend_state_t state)
> > +{
> > +	return 0;
> > +}
> > +static inline int regulator_suspend_finish(void)
> > +{
> > +	return 0;
> > +}
> >  #endif
> >  
> >  #endif

My solution would have been:

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 603820e..0f3f860 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -25,6 +25,7 @@ menuconfig ARCH_EXYNOS
 	select S5P_DEV_MFC
 	select SRAM
 	select MFD_SYSCON
+	select REGULATOR if PM_SLEEP
 	help
 	  Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5)

But that will work too, so:

Acked-by: Joerg Roedel <jroedel@suse.de>

  reply	other threads:[~2015-02-04 15:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 10:45 [PATCH] regulator: Fix build breakage on !REGULATOR Krzysztof Kozlowski
2015-02-04 10:50 ` Krzysztof Kozlowski
2015-02-04 15:22   ` Joerg Roedel [this message]
2015-02-04 11:23 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150204152259.GN3702@8bytes.org \
    --to=joro@8bytes.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.