All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: trinity@vger.kernel.org
Subject: Re: [patch] update perf_event_open() for Linux 3.19
Date: Wed, 4 Feb 2015 15:46:32 -0500	[thread overview]
Message-ID: <20150204204632.GA2551@codemonkey.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.11.1502041538420.5222@vincent-weaver-1.umelst.maine.edu>

On Wed, Feb 04, 2015 at 03:41:17PM -0500, Vince Weaver wrote:
 > On Wed, 4 Feb 2015, Dave Jones wrote:
 > 
 > > On Tue, Feb 03, 2015 at 12:01:23PM -0500, Vince Weaver wrote:
 > > 
 > > 
 > >  > @@ -237,6 +238,7 @@ enum perf_event_read_format {
 > >  >  #define PERF_ATTR_SIZE_VER2	80	/* add: branch_sample_type */
 > >  >  #define PERF_ATTR_SIZE_VER3	96	/* add: sample_regs_user */
 > >  >  					/* add: sample_stack_user */
 > >  > +#define PERF_ATTR_SIZE_VER4	104	/* add: sample_regs_intr */
 > > 
 > > I've not given this a lot of thought before, but I'm assuming these
 > > are the 64-bit struct sizes.  It might be interesting to also
 > > throw some 32-bit sizes in the mix.  Who knows what horrors
 > > lie in wait for the compat syscalls.
 > 
 > I might be misunderstanding, but I think the attr structure is defined in 
 > a way that it has the same size on 32 and 64 bit.

ah, ok. Yeah, now that I look at the struct definition, it's all
u32/u64's, so this is the same size on both archs.

	Dave

      reply	other threads:[~2015-02-04 20:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03 17:01 [patch] update perf_event_open() for Linux 3.19 Vince Weaver
2015-02-04 20:31 ` Dave Jones
2015-02-04 20:41   ` Vince Weaver
2015-02-04 20:46     ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150204204632.GA2551@codemonkey.org.uk \
    --to=davej@codemonkey.org.uk \
    --cc=trinity@vger.kernel.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.