From: Dave Chinner <david@fromorbit.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 5/8 v4] tests/generic: relocate xfs's tests into tests/generic/
Date: Thu, 5 Feb 2015 13:19:57 +1100 [thread overview]
Message-ID: <20150205021957.GF12722@dastard> (raw)
In-Reply-To: <1423004840-45315-6-git-send-email-jaegeuk@kernel.org>
On Tue, Feb 03, 2015 at 03:07:17PM -0800, Jaegeuk Kim wrote:
> This patch moves the generic testcases defined in xfs into tests/generic/.
> * xfs/053 -> generic/054
> xfs/137 -> generic/137
> xfs/138 -> generic/138
> xfs/139 -> generic/139
> xfs/140 -> generic/140
> xfs/179 -> generic/179
> xfs/180 -> generic/180
> xfs/182 -> generic/182
> xfs/200 -> generic/200
> * xfs/306 -> generic/305
>
> * The test number was changed to address conflicts.
Just rename them all to the lowest unused numbers in the generic/ test
directory.
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> tests/generic/054 | 102 ++++++++++++++++++++++++++++++++++++++++
> tests/generic/054.out | 10 ++++
You should tell git to use a diff format that track renames. i.e
$ git diff -M 97bf6af..2155355
diff --git a/fs/xfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
similarity index 100%
rename from fs/xfs/xfs_fs.h
rename to fs/xfs/libxfs/xfs_fs.h
$
$
$ git diff --stat -M 97bf6af..2155355
fs/xfs/{ => libxfs}/xfs_fs.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
$
It's much easier to review rename patches in this format. :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-02-05 2:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 23:07 [PATCH 0/8 v4] make xfs/tests generic by introducing shutdown for filesystems Jaegeuk Kim
2015-02-03 23:07 ` [PATCH 1/8 v4] common/rc: add _require_scratch_shtudown Jaegeuk Kim
2015-02-05 2:01 ` Dave Chinner
2015-02-03 23:07 ` [PATCH 2/8 v4] common/rc: add _require_bmap Jaegeuk Kim
2015-02-05 2:05 ` Dave Chinner
2015-02-03 23:07 ` [PATCH 3/8 v4] common/rc: add _require_norecovery Jaegeuk Kim
2015-02-05 2:08 ` Dave Chinner
2015-02-03 23:07 ` [PATCH 4/8 v4] tests/xfs: convert 10 xfs's tests to be generic ones Jaegeuk Kim
2015-02-05 2:11 ` Dave Chinner
2015-02-03 23:07 ` [PATCH 5/8 v4] tests/generic: relocate xfs's tests into tests/generic/ Jaegeuk Kim
2015-02-05 2:19 ` Dave Chinner [this message]
2015-02-03 23:07 ` [PATCH 6/8 v4] common/rc: define dump.f2fs and logstate for f2fs Jaegeuk Kim
2015-02-05 2:48 ` Dave Chinner
2015-02-03 23:07 ` [PATCH 7/8 v4] tests/xfs: add f2fs testcase and convert them being generic Jaegeuk Kim
2015-02-05 3:12 ` Dave Chinner
2015-02-03 23:07 ` [PATCH 8/8 v4] tests/generic: relocate four xfs's tests into tests/generic/ Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205021957.GF12722@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.