From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCHv1] xenbus: Add proper handling of XS_ERROR from Xenbus for transactions. Date: Thu, 5 Feb 2015 14:40:09 -0500 Message-ID: <20150205194009.GG11646@x230.dumpdata.com> References: <1423148560-25957-1-git-send-email-david.vrabel@citrix.com> <54D3874F.3090106@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YJSHj-0006Uo-9o for xen-devel@lists.xenproject.org; Thu, 05 Feb 2015 19:40:19 +0000 Content-Disposition: inline In-Reply-To: <54D3874F.3090106@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky , Jennifer Herbert List-Id: xen-devel@lists.xenproject.org On Thu, Feb 05, 2015 at 03:07:59PM +0000, David Vrabel wrote: > On 05/02/15 15:02, David Vrabel wrote: > > From: Jennifer Herbert > > > > If Xenstore sends back a XS_ERROR for TRANSACTION_END, the driver BUGs > > because it cannot find the matching transaction in the list. For > > TRANSACTION_START, it leaks memory. > > > > Check the message as returned from xenbus_dev_request_and_reply(), and > > clean up for TRANSACTION_START or discard the error for > > TRANSACTION_END. > > Applied to devel/for-linus-3.20, thanks. You are thanking yourself :-) ? Maybe it is time for some vacation? > > David > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel