All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: Cyril Bur <cyrilbur@gmail.com>
Cc: linux-kernel@vger.kernel.org, mpe@ellerman.id.au,
	drjones@redhat.com, akpm@linux-foundation.org, mingo@kernel.org,
	uobergfe@redhat.com, chaiw.fnst@cn.fujitsu.com, fabf@skynet.be,
	atomlin@redhat.com, benzh@chromium.org, schwidefsky@de.ibm.com
Subject: Re: [PATCH v2 0/2] Quieten softlockup detector on virtualised kernels
Date: Thu, 5 Feb 2015 15:48:49 -0500	[thread overview]
Message-ID: <20150205204849.GS234357@redhat.com> (raw)
In-Reply-To: <1420774478-16760-1-git-send-email-cyrilbur@gmail.com>

On Fri, Jan 09, 2015 at 02:34:36PM +1100, Cyril Bur wrote:
> When the hypervisor pauses a virtualised kernel the kernel will observe a jump
> in timebase, this can cause spurious messages from the softlockup detector.
> 
> Whilst these messages are harmless, they are accompanied with a stack trace
> which causes undue concern and more problematically the stack trace in the
> guest has nothing to do with the observed problem and can only be misleading.

Originally I was suggesting to talk with the x86/kvm folks about coming up
with a common solution.  But I didn't hear a response from those cc'd at
the time.  This solution looks a lot cleaner than what x86 is doing.

I am willing to see how this works out on ppc64's kvm and see if they still
see any issues after awhile.  If not, maybe I can poke the x86 folks to
migrate to something similar.

Acked-by: Don Zickus <dzickus@redhat.com>

> 
> Futhermore, on POWER8 this is completely avoidable with the introduction of
> the Virtual Time Base (VTB) register.
> 
> V2:
> 	Remove the export of running_clock
> 	Added #ifdef CONFIG_PPC_PSERIES and optimised the non lpar + vtb cases.
> 	Replaced the use of sched_clock_with local_clock it was used originally in
> the softlockup detector.
> 
> Cyril Bur (2):
>   Add another clock for use with the soft lockup watchdog.
>   powerpc: add running_clock for powerpc to prevent spurious softlockup
>     warnings
> 
>  arch/powerpc/kernel/time.c | 32 ++++++++++++++++++++++++++++++++
>  include/linux/sched.h      |  1 +
>  kernel/sched/clock.c       | 13 +++++++++++++
>  kernel/watchdog.c          |  2 +-
>  4 files changed, 47 insertions(+), 1 deletion(-)
> 
> -- 
> 1.9.1
> 

      parent reply	other threads:[~2015-02-05 20:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09  3:34 [PATCH v2 0/2] Quieten softlockup detector on virtualised kernels Cyril Bur
2015-01-09  3:34 ` [PATCH v2 1/2] Add another clock for use with the soft lockup watchdog Cyril Bur
2015-02-10  6:19   ` Chai Wen
2015-01-09  3:34 ` [PATCH v2 2/2] powerpc: add running_clock for powerpc to prevent spurious softlockup warnings Cyril Bur
2015-02-04 10:42   ` Paul Bolle
2015-02-05  4:08     ` Cyril Bur
2015-02-02  4:58 ` [PATCH v2 0/2] Quieten softlockup detector on virtualised kernels Cyril Bur
2015-02-02 23:08   ` Andrew Morton
2015-02-05 20:48 ` Don Zickus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150205204849.GS234357@redhat.com \
    --to=dzickus@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@redhat.com \
    --cc=benzh@chromium.org \
    --cc=chaiw.fnst@cn.fujitsu.com \
    --cc=cyrilbur@gmail.com \
    --cc=drjones@redhat.com \
    --cc=fabf@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=schwidefsky@de.ibm.com \
    --cc=uobergfe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.