From: Daniel Vetter <daniel@ffwll.ch>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/5] drm/i915: Make sure the primary plane is enabled before reading out the fb state
Date: Fri, 6 Feb 2015 09:41:31 +0100 [thread overview]
Message-ID: <20150206084131.GC14009@phenom.ffwll.local> (raw)
In-Reply-To: <20150205210053.GC9625@intel.com>
On Thu, Feb 05, 2015 at 01:00:53PM -0800, Matt Roper wrote:
> On Thu, Feb 05, 2015 at 07:35:13PM +0000, Damien Lespiau wrote:
> > We don't want to end up in a state where we track that the pipe has its
> > primary plane enabled when primary plane registers are programmed with
> > values that look possible but the plane actually disabled.
> >
> > Refuse to read out the fb state when the primary plane isn't enabled.
> >
> > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Suggested-by: Matt Roper <matthew.d.roper@intel.com>
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> For the series:
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
All merged, thanks for patches&review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-02-06 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 17:22 [PATCH 0/5] Fix a couple of warning introduced recently Damien Lespiau
2015-02-05 17:22 ` [PATCH 1/5] drm/i915: Put update_state_fb() next to the fb update Damien Lespiau
2015-02-05 17:22 ` [PATCH 2/5] drm/i915: Use an intermediate variable to avoid repeating ourselves Damien Lespiau
2015-02-05 17:22 ` [PATCH 3/5] drm/i915: Don't try to reference the fb in get_initial_plane_config() Damien Lespiau
2015-02-05 18:24 ` Matt Roper
2015-02-05 18:30 ` [PATCH 3/5 v2] " Damien Lespiau
2015-02-05 17:22 ` [PATCH 4/5] drm/i915: Store the initial framebuffer in initial_plane_config Damien Lespiau
2015-02-05 17:22 ` [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb Damien Lespiau
2015-02-05 18:10 ` Matt Roper
2015-02-05 18:32 ` Ville Syrjälä
2015-02-05 18:58 ` Damien Lespiau
2015-02-05 19:12 ` Matt Roper
2015-02-05 19:20 ` Damien Lespiau
2015-02-05 19:24 ` [PATCH 5/5 v2] " Damien Lespiau
2015-02-05 19:35 ` [PATCH 6/5] drm/i915: Make sure the primary plane is enabled before reading out the fb state Damien Lespiau
2015-02-05 21:00 ` Matt Roper
2015-02-06 8:41 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150206084131.GC14009@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.