From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v3 20/20] arm: mach-pxa: Decrement the power supply's device reference counter Date: Fri, 6 Feb 2015 15:59:05 +0100 Message-ID: <20150206145904.GA7872@amd> References: <1422629278-12202-1-git-send-email-k.kozlowski@samsung.com> <1422629278-12202-21-git-send-email-k.kozlowski@samsung.com> <20150206134953.GA25683@amd> <1423233788.31516.5.camel@AMDC1943> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1423233788.31516.5.camel@AMDC1943> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Krzysztof Kozlowski Cc: Milo Kim , x86@kernel.org, Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Linus Walleij , platform-driver-x86@vger.kernel.org, "H. Peter Anvin" , Lee Jones , ac100@lists.launchpad.net, devel@driverdev.osuosl.org, Russell King , Samuel Ortiz , Dmitry Eremin-Solenikov , Robert Jarzmik , patches@opensource.wolfsonmicro.com, linux-acpi@vger.kernel.org, Cezary Jackiewicz , Ingo Molnar , linux-input@vger.kernel.org, Darren Hart , Len Brown , linux-pm@vger.kernel.org, Julian Andres Klode , Haojian Zhuang , linux-tegra@vger.k List-Id: linux-acpi@vger.kernel.org T24gRnJpIDIwMTUtMDItMDYgMTU6NDM6MDgsIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6Cj4g T24gcGnEhSwgMjAxNS0wMi0wNiBhdCAxNDo0OSArMDEwMCwgUGF2ZWwgTWFjaGVrIHdyb3RlOgo+ ID4gT24gRnJpIDIwMTUtMDEtMzAgMTU6NDc6NTgsIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6 Cj4gPiA+IFVzZSBwb3dlcl9zdXBwbHlfcHV0KCkgdG8gZGVjcmVtZW50IHRoZSBwb3dlciBzdXBw bHkncyBkZXZpY2UgcmVmZXJlbmNlCj4gPiA+IGNvdW50ZXIuCj4gPiA+IAo+ID4gPiBTaWduZWQt b2ZmLWJ5OiBLcnp5c3p0b2YgS296bG93c2tpIDxrLmtvemxvd3NraUBzYW1zdW5nLmNvbT4KPiA+ ID4gUmV2aWV3ZWQtYnk6IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBz YW1zdW5nLmNvbT4KPiA+ID4gUmV2aWV3ZWQtYnk6IFNlYmFzdGlhbiBSZWljaGVsIDxzcmVAa2Vy bmVsLm9yZz4KPiA+IAo+ID4gMTEsMTMsMjAgbm90aGluZyBvYnZpb3VzbHkgd3JvbmcuIEJ1dCBJ J20gbm90IHN1cmUgaWYgSSBzdHVkaWVkIHRoZW0KPiA+IGNsb3NlbHkgZW5vdWdoIHRvIHdhcnJh bnQgYW4gQUNLLgo+ID4gCj4gPiBJdCB3b3VsZCBiZSBnb29kIHRvIGdldCB0aGlzIGludG8ga2Vy bmVsIC0tIEkgc2VlbiBubyBiYWQgY29tbWVudHMsCj4gPiBhbmQgaXQgaXMgbm90IGdvaW5nIHRv IGltcHJvdmUgd2l0aG91dCBtZXJnZSBpbnRvIG1haW5saW5lLgo+IAo+IFRoYW5rcyBmb3IgbG9v a2luZyBhdCBwYXRjaHNldC4gSXQgd291bGQgYmUgcmVhbGx5IG5pY2UgaWYgdGhpcyBjb3VsZCBi ZQo+IHRlc3RlZCBmb3Igc29tZSB0aW1lIGluIGxpbnV4LW5leHQuIFN1Y2ggdGVzdGluZyB3b3Vs ZCBoZWxwIGEgbG90LiBCdXQgSQo+IG5lZWQgYWNrcyBmcm9tIHZhcmlvdXMgbWFpbnRhaW5lcnMg Zm9yIHRoYXQuCgpBY3R1YWxseSwgeW91IGRvbid0LiBUaGUgdmFyaW91cyBtYWludGFpbmVycyBj bGVhcmx5IGRvbid0IGNhcmUgYXQKdGhpcyBwb2ludC4gVGhleSBoYWQgZW5vdWdoIHRpbWUuIFNv IHlvdSBzZWxlY3Qgb25lIG1haW50YWluZXIgeW91CndhbnQgdG8gcHVzaCB0aGlzIHRocm91Z2gs IGFuZCB5b3UgcHVzaCBpdC4KClNvbWVvbmUgbWF5IGNvbXBsYWluLCBzbyB5b3UnbGwgc29sdmUg dGhlIGZlZWRiYWNrLi4uCgpHb29kIGx1Y2ssCgkJCQkJCQkJCVBhdmVsCgo+IE9mIGNvdXJzZSB0 aGUgcGF0Y2hzZXQgdG8gYmlnIGVub3VnaCB0byBnbyBpbnRvIDMuMjAuIElmIG5lZWRlZCB0aGlz Cj4gY291bGQgYmUgdGFrZW4gZ3JhZHVhbGx5IGluIGZvbGxvd2luZyBzdGVwczoKPiAxLiBQYXRj aGVzIDEtMiAocGF0Y2ggMiB0b3VjaGVzICphbGwgZHJpdmVycyopLAo+IDIuIFBhdGNoZXMgMy0x MCAodG91Y2ggb25seSBpbmRpdmlkdWFsIGRyaXZlcnMpLAo+IDMuIFBhdGNoIDExIChhZ2FpbiAq ZXZlcnl0aGluZyogY2hhbmdlZCksCj4gNC4gUGF0Y2hlcyAxMi0yMCAoaW5kaXZpZHVhbCBjaGFu Z2VzKS4KPiAKPiBJbiBzdWNoIGNhc2UgSSB3aWxsIHJlZnJlc2ggZXZlcnl0aGluZyBhZnRlciBl YWNoIHN0ZXAgc28gbmV3IGRyaXZlcnMKPiB3b3VsZCBiZSBhbHNvIHVwZGF0ZWQuCj4gCj4gVGhh bmtzIGFnYWluIFBhdmVsIGZvciBwcm9tcHQgcmVwbGllcy4KCi0tIAooZW5nbGlzaCkgaHR0cDov L3d3dy5saXZlam91cm5hbC5jb20vfnBhdmVsbWFjaGVrCihjZXNreSwgcGljdHVyZXMpIGh0dHA6 Ly9hdHJleS5rYXJsaW4ubWZmLmN1bmkuY3ovfnBhdmVsL3BpY3R1cmUvaG9yc2VzL2Jsb2cuaHRt bApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBt YWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2 LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Fri, 6 Feb 2015 15:59:05 +0100 Subject: [PATCH v3 20/20] arm: mach-pxa: Decrement the power supply's device reference counter In-Reply-To: <1423233788.31516.5.camel@AMDC1943> References: <1422629278-12202-1-git-send-email-k.kozlowski@samsung.com> <1422629278-12202-21-git-send-email-k.kozlowski@samsung.com> <20150206134953.GA25683@amd> <1423233788.31516.5.camel@AMDC1943> Message-ID: <20150206145904.GA7872@amd> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote: > On pi?, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > > Use power_supply_put() to decrement the power supply's device reference > > > counter. > > > > > > Signed-off-by: Krzysztof Kozlowski > > > Reviewed-by: Bartlomiej Zolnierkiewicz > > > Reviewed-by: Sebastian Reichel > > > > 11,13,20 nothing obviously wrong. But I'm not sure if I studied them > > closely enough to warrant an ACK. > > > > It would be good to get this into kernel -- I seen no bad comments, > > and it is not going to improve without merge into mainline. > > Thanks for looking at patchset. It would be really nice if this could be > tested for some time in linux-next. Such testing would help a lot. But I > need acks from various maintainers for that. Actually, you don't. The various maintainers clearly don't care at this point. They had enough time. So you select one maintainer you want to push this through, and you push it. Someone may complain, so you'll solve the feedback... Good luck, Pavel > Of course the patchset to big enough to go into 3.20. If needed this > could be taken gradually in following steps: > 1. Patches 1-2 (patch 2 touches *all drivers*), > 2. Patches 3-10 (touch only individual drivers), > 3. Patch 11 (again *everything* changed), > 4. Patches 12-20 (individual changes). > > In such case I will refresh everything after each step so new drivers > would be also updated. > > Thanks again Pavel for prompt replies. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758180AbbBFPBW (ORCPT ); Fri, 6 Feb 2015 10:01:22 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35220 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755548AbbBFO7J (ORCPT ); Fri, 6 Feb 2015 09:59:09 -0500 Date: Fri, 6 Feb 2015 15:59:05 +0100 From: Pavel Machek To: Krzysztof Kozlowski Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Jiri Kosina , David Herrmann , Cezary Jackiewicz , Darren Hart , Support Opensource , Milo Kim , Julian Andres Klode , Marc Dietrich , Greg Kroah-Hartman , linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@opensource.wolfsonmicro.com, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, Linus Walleij , Samuel Ortiz , Lee Jones , linux-arm-kernel@lists.infradead.org, Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Thomas Gleixner , Kyungmin Park , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v3 20/20] arm: mach-pxa: Decrement the power supply's device reference counter Message-ID: <20150206145904.GA7872@amd> References: <1422629278-12202-1-git-send-email-k.kozlowski@samsung.com> <1422629278-12202-21-git-send-email-k.kozlowski@samsung.com> <20150206134953.GA25683@amd> <1423233788.31516.5.camel@AMDC1943> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1423233788.31516.5.camel@AMDC1943> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote: > On pią, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > > Use power_supply_put() to decrement the power supply's device reference > > > counter. > > > > > > Signed-off-by: Krzysztof Kozlowski > > > Reviewed-by: Bartlomiej Zolnierkiewicz > > > Reviewed-by: Sebastian Reichel > > > > 11,13,20 nothing obviously wrong. But I'm not sure if I studied them > > closely enough to warrant an ACK. > > > > It would be good to get this into kernel -- I seen no bad comments, > > and it is not going to improve without merge into mainline. > > Thanks for looking at patchset. It would be really nice if this could be > tested for some time in linux-next. Such testing would help a lot. But I > need acks from various maintainers for that. Actually, you don't. The various maintainers clearly don't care at this point. They had enough time. So you select one maintainer you want to push this through, and you push it. Someone may complain, so you'll solve the feedback... Good luck, Pavel > Of course the patchset to big enough to go into 3.20. If needed this > could be taken gradually in following steps: > 1. Patches 1-2 (patch 2 touches *all drivers*), > 2. Patches 3-10 (touch only individual drivers), > 3. Patch 11 (again *everything* changed), > 4. Patches 12-20 (individual changes). > > In such case I will refresh everything after each step so new drivers > would be also updated. > > Thanks again Pavel for prompt replies. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html